[Tidy First] Re-lint imports section of test_base_resource.py
#10095
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was done by running `pre-commit run --all`. That this was needed is a temporary glitch in how our `Tests and Code Checks` github action works on PRs. Basically we added `isort` to the pre-commit hooks recently, and this does additional linting/formatting on our imports. People reasonably have branches which were started prior to `isort` being part of the pre-commit hooks on main. Thus, unless those branches get caught up to main, the github action on associated PRs won't run `isort` because it doesn't exist on those branchs. Once everyone gets their local `main` branch updated (I suspect this might take a few days) this problem will go away.
QMalcolm
added
Skip Changelog
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #10095 +/- ##
==========================================
- Coverage 88.21% 88.17% -0.05%
==========================================
Files 181 181
Lines 22748 22748
==========================================
- Hits 20068 20057 -11
- Misses 2680 2691 +11
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
MichelleArk
approved these changes
May 6, 2024
ChenyuLInx
approved these changes
May 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was done by running
pre-commit run --all. That this was needed is a temporary glitch in how ourTests and Code Checksgithub action works on PRs. Basically we addedisortto the pre-commit hooks recently, and this does additional linting/formatting on our imports.People reasonably have branches which were started prior to
isortbeing part of the pre-commit hooks on main. Thus, unless those branches get caught up to main, the github action on associated PRs won't runisortbecause it doesn't exist on those branchs. Once everyone gets their localmainbranch updated (I suspect this might take a few days) this problem will go away.