Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Tidy First] Re-lint imports section of test_base_resource.py #10095

Merged
merged 1 commit into from
May 6, 2024
Merged

[Tidy First] Re-lint imports section of test_base_resource.py #10095

merged 1 commit into from
May 6, 2024

Commits on May 6, 2024

  1. re-lint imports section of test_base_resource.py 

    This was done by running `pre-commit run --all`. That this was needed
is a temporary glitch in how our `Tests and Code Checks` github action
works on PRs. Basically we added `isort` to the pre-commit hooks recently, and
this does additional linting/formatting on our imports.

People reasonably have branches which were started prior to `isort` being
part of the pre-commit hooks on main. Thus, unless those branches get caught
up to main, the github action on associated PRs won't run `isort` because
it doesn't exist on those branchs. Once everyone gets their local `main`
branch updated (I suspect this might take a few days) this problem will go
away.
    @QMalcolm
    QMalcolm committed May 6, 2024
    Configuration menu
    Copy the full SHA
    01dd73b View commit details
    Browse the repository at this point in the history