Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CT-1475] [Bug] Automatic Backport fails #6217

Open
2 tasks done
emmyoop opened this issue Nov 4, 2022 · 6 comments
Open
2 tasks done

[CT-1475] [Bug] Automatic Backport fails #6217

emmyoop opened this issue Nov 4, 2022 · 6 comments
Labels
repo ci/cd Testing and continuous integration for dbt-core + adapter plugins tech_debt Behind-the-scenes changes, with little direct impact on end-user functionality

Comments

@emmyoop
Copy link
Member

emmyoop commented Nov 4, 2022 •
edited
Loading

Is this a new bug in dbt-core?

  • I believe this is a new bug in dbt-core
  • I have searched the existing issues, and I could not find an existing issue for this bug

Current Behavior

We currently had to do some backports to 1.1.latest, 1.2.latest and 1.3.latest (original PR)

The 1.3.latest backport worked flawlessly.

However the 1.1.latest and the 1.2.latest both failed. When I manually cherry picked the commits I was able to do it without conflict so it's unclear why the cherry picks failed.

Additionally, I was told that if the labels are added before the PR has been merged, the backport will not happen. the labels must be added after the merge is complete. Unsure if this is a bug or just how it works but wanted to note it here as well.

Expected Behavior

Backports just work - always!

Steps To Reproduce

See #6204
@emmyoop emmyoop added bug Something isn't working triage labels Nov 4, 2022
@github-actions github-actions bot changed the title [Bug] Automatic Backport fails [CT-1475] [Bug] Automatic Backport fails Nov 4, 2022
@emmyoop emmyoop added repo ci/cd Testing and continuous integration for dbt-core + adapter plugins and removed triage labels Nov 4, 2022
@emmyoop
Copy link
Member Author

emmyoop commented Nov 4, 2022

@McKnight-42 did you experience something similar with any of the adapters?

@emmyoop
Copy link
Member Author

emmyoop commented Nov 4, 2022

Inof: backport to 1.2.latest worked for #6202 today

@McKnight-42
Copy link
Contributor

@emmyoop yeah 1.2. and 1.1 both fails with dbt-snowflake dbt-labs/dbt-redshift#211

@emmyoop
Copy link
Member Author

emmyoop commented Dec 7, 2022

More examples in #6405

@McKnight-42
Copy link
Contributor

more examples dbt-labs/dbt-bigquery#411 if we are collecting them.

@jtcohen6 jtcohen6 added tech_debt Behind-the-scenes changes, with little direct impact on end-user functionality and removed bug Something isn't working labels Jan 15, 2023
@emmyoop
Copy link
Member Author

emmyoop commented Sep 27, 2023

The most stright forward solution may be to write our own version of the backport so we can be more in control of how it functions and see the actual reason it's failing.

@martynydbt martynydbt assigned gshank and unassigned peterallenwebb Nov 7, 2023
@jtcohen6 jtcohen6 mentioned this issue Nov 9, 2023
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
repo ci/cd Testing and continuous integration for dbt-core + adapter plugins tech_debt Behind-the-scenes changes, with little direct impact on end-user functionality
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@gshank @peterallenwebb @emmyoop @jtcohen6 @McKnight-42