-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updates lib to use new profile name functionality #6202
Merged
ChenyuLInx
merged 3 commits into
main
from
racheld/RUNTIME-560/pass-profile-name-to-runtime-config
Nov 4, 2022
Merged
Updates lib to use new profile name functionality #6202
ChenyuLInx
merged 3 commits into
main
from
racheld/RUNTIME-560/pass-profile-name-to-runtime-config
Nov 4, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide. |
iknox-fa
approved these changes
Nov 2, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
stu-k
approved these changes
Nov 3, 2022
ChenyuLInx
deleted the
racheld/RUNTIME-560/pass-profile-name-to-runtime-config
branch
November 4, 2022 17:05
ChenyuLInx
added
backport 1.2.latest
This PR will be backported to the 1.2.latest branch
backport 1.3.latest
labels
Nov 4, 2022
github-actions bot
pushed a commit
that referenced
this pull request
Nov 4, 2022
* Updates lib to use new profile name functionality * Adds changie entry * Fixes formatting (cherry picked from commit d0543c9)
github-actions bot
pushed a commit
that referenced
this pull request
Nov 4, 2022
* Updates lib to use new profile name functionality * Adds changie entry * Fixes formatting (cherry picked from commit d0543c9)
2 tasks
leahwicz
added a commit
that referenced
this pull request
Nov 16, 2022
* Updates lib to use new profile name functionality * Adds changie entry * Fixes formatting (cherry picked from commit d0543c9) Co-authored-by: Rachel <41338402+racheldaniel@users.noreply.github.com> Co-authored-by: leahwicz <60146280+leahwicz@users.noreply.github.com>
leahwicz
added a commit
that referenced
this pull request
Nov 16, 2022
* Updates lib to use new profile name functionality * Adds changie entry * Fixes formatting (cherry picked from commit d0543c9) Co-authored-by: Rachel <41338402+racheldaniel@users.noreply.github.com> Co-authored-by: leahwicz <60146280+leahwicz@users.noreply.github.com>
6 tasks
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #6201
Description
In order to dynamically pass a profile name to RuntimeConfig creation from the dbt-server, we want to make use of the refactor made in this branch.
We will wait to merge this until above changes have been backported to
1.3.0-latest
(pending PR), and will need to backport this to1.3.0-latest
and1.2.0-latest
Checklist
changie new
to create a changelog entry