Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates lib to use new profile name functionality #6202

Merged

Conversation

racheldaniel
Copy link
Contributor

@racheldaniel racheldaniel commented Nov 2, 2022

resolves #6201

Description

In order to dynamically pass a profile name to RuntimeConfig creation from the dbt-server, we want to make use of the refactor made in this branch.

We will wait to merge this until above changes have been backported to 1.3.0-latest (pending PR), and will need to backport this to 1.3.0-latest and 1.2.0-latest

Checklist

@racheldaniel racheldaniel requested review from a team and stu-k November 2, 2022 19:57
@cla-bot cla-bot bot added the cla:yes label Nov 2, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Nov 2, 2022

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide.

@racheldaniel racheldaniel requested a review from a team as a code owner November 2, 2022 20:00
@racheldaniel racheldaniel requested a review from sgrebnov November 2, 2022 20:00
Copy link
Contributor

@iknox-fa iknox-fa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ChenyuLInx ChenyuLInx merged commit d0543c9 into main Nov 4, 2022
@ChenyuLInx ChenyuLInx deleted the racheld/RUNTIME-560/pass-profile-name-to-runtime-config branch November 4, 2022 17:05
@ChenyuLInx ChenyuLInx added backport 1.2.latest This PR will be backported to the 1.2.latest branch backport 1.3.latest labels Nov 4, 2022
github-actions bot pushed a commit that referenced this pull request Nov 4, 2022
* Updates lib to use new profile name functionality

* Adds changie entry

* Fixes formatting

(cherry picked from commit d0543c9)
github-actions bot pushed a commit that referenced this pull request Nov 4, 2022
* Updates lib to use new profile name functionality

* Adds changie entry

* Fixes formatting

(cherry picked from commit d0543c9)
leahwicz added a commit that referenced this pull request Nov 16, 2022
* Updates lib to use new profile name functionality

* Adds changie entry

* Fixes formatting

(cherry picked from commit d0543c9)

Co-authored-by: Rachel <41338402+racheldaniel@users.noreply.github.com>
Co-authored-by: leahwicz <60146280+leahwicz@users.noreply.github.com>
leahwicz added a commit that referenced this pull request Nov 16, 2022
* Updates lib to use new profile name functionality

* Adds changie entry

* Fixes formatting

(cherry picked from commit d0543c9)

Co-authored-by: Rachel <41338402+racheldaniel@users.noreply.github.com>
Co-authored-by: leahwicz <60146280+leahwicz@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 1.2.latest This PR will be backported to the 1.2.latest branch backport 1.3.latest cla:yes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CT-1468] [Feature] Use new profile name handling in lib file for dbt-server
4 participants