Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 1.3.latest] Updates lib to use new profile name functionality #6221

Merged
merged 2 commits into from
Nov 16, 2022

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Nov 4, 2022

Backport d0543c9 from #6202.

* Updates lib to use new profile name functionality

* Adds changie entry

* Fixes formatting

(cherry picked from commit d0543c9)
@github-actions github-actions bot requested a review from a team November 4, 2022 17:06
@github-actions github-actions bot requested a review from a team as a code owner November 4, 2022 17:06
@cla-bot cla-bot bot added the cla:yes label Nov 4, 2022
@ChenyuLInx ChenyuLInx closed this Nov 4, 2022
@ChenyuLInx ChenyuLInx reopened this Nov 4, 2022
@leahwicz
Copy link
Contributor

leahwicz commented Nov 4, 2022

@racheldaniel @ChenyuLInx (fyi I just plan to ask this for all backports- maybe I'll add it to the template) - 1) what is the risk this introduces 2) is this new a feature or breaking to current functionality

@leahwicz leahwicz requested review from jtcohen6 and leahwicz and removed request for a team, ChenyuLInx and lostmygithubaccount November 4, 2022 19:10
@racheldaniel
Copy link
Contributor

@leahwicz I'm sorry I missed your comment before! Assuming that the previous refactor this was based on (this PR) did not introduce any risk, this refactor should not carry risk. Functionality will remain the same (so this can go out before all of our related changes including those in dbt-server go out with no risk), this change just allows us to stop manipulating a project's dbt_project.yml file upstream.

@leahwicz leahwicz merged commit 54d1865 into 1.3.latest Nov 16, 2022
@leahwicz leahwicz deleted the backport-6202-to-1.3.latest branch November 16, 2022 03:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants