Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add python version to main workflow and upgrade action #6204

Merged
merged 1 commit into from
Nov 3, 2022

Conversation

emmyoop
Copy link
Member

@emmyoop emmyoop commented Nov 3, 2022

resolves #6203

Description

  1. Upgrade actions/setup-python from v2 to v4.3.0 to bring in all the updates for deprecations
  2. Defines Python Version to use when installing dependencies

Checklist

@emmyoop emmyoop requested a review from leahwicz as a code owner November 3, 2022 13:41
@cla-bot cla-bot bot added the cla:yes label Nov 3, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Nov 3, 2022

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide.

uses: actions/setup-python@v2
uses: actions/setup-python@v4.3.0
with:
python-version: '3.8'
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using 3.8 here to be consistent with everywhere else we define a python version (build step and release process)

with:
python-version: 3.8
python-version: '3.8'
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the recommended syntax by the action

@emmyoop emmyoop added the Skip Changelog Skips GHA to check for changelog file label Nov 3, 2022
@emmyoop emmyoop merged commit c3ccbe3 into main Nov 3, 2022
@emmyoop emmyoop deleted the er/ct-1469-python-version branch November 3, 2022 14:13
@emmyoop emmyoop added backport 1.1.latest backport 1.2.latest This PR will be backported to the 1.2.latest branch backport 1.3.latest labels Nov 3, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Nov 3, 2022

The backport to 1.2.latest failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-1.2.latest 1.2.latest
# Navigate to the new working tree
cd .worktrees/backport-1.2.latest
# Create a new branch
git switch --create backport-6204-to-1.2.latest
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 c3ccbe3357d15e45153c70b62bea626d37fc0d05
# Push it to GitHub
git push --set-upstream origin backport-6204-to-1.2.latest
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-1.2.latest

Then, create a pull request where the base branch is 1.2.latest and the compare/head branch is backport-6204-to-1.2.latest.

@github-actions
Copy link
Contributor

github-actions bot commented Nov 3, 2022

The backport to 1.1.latest failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-1.1.latest 1.1.latest
# Navigate to the new working tree
cd .worktrees/backport-1.1.latest
# Create a new branch
git switch --create backport-6204-to-1.1.latest
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 c3ccbe3357d15e45153c70b62bea626d37fc0d05
# Push it to GitHub
git push --set-upstream origin backport-6204-to-1.1.latest
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-1.1.latest

Then, create a pull request where the base branch is 1.1.latest and the compare/head branch is backport-6204-to-1.1.latest.

github-actions bot pushed a commit that referenced this pull request Nov 3, 2022
emmyoop added a commit that referenced this pull request Nov 3, 2022
emmyoop added a commit that referenced this pull request Nov 3, 2022
emmyoop added a commit that referenced this pull request Nov 3, 2022
emmyoop added a commit that referenced this pull request Nov 3, 2022
(cherry picked from commit c3ccbe3)

Co-authored-by: Emily Rockman <emily.rockman@dbtlabs.com>
emmyoop added a commit that referenced this pull request Nov 3, 2022
stu-k pushed a commit that referenced this pull request Nov 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 1.1.latest backport 1.2.latest This PR will be backported to the 1.2.latest branch backport 1.3.latest cla:yes Skip Changelog Skips GHA to check for changelog file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CT-1469] [Bug] Define Python Version when Installing Dependencies
2 participants