[CT-3322] [Bug] Incorrect behaviour described in docstring for get_custom_database macro

[LeoTheGriff]

Is this a new bug in dbt-core?

• I believe this is a new bug in dbt-core
• I have searched the existing issues, and I could not find an existing issue for this bug

Current Behavior

Incorrect behaviour described in docstring for get_custom_database macro: describes postfix when it is replacement of database target.

Expected Behavior

Docstring for get_custom_database macro describes replacement of database target.

Steps To Reproduce

N/A

Relevant log output

No response

Environment

No response

Which database adapter are you using with dbt?

No response

Additional Context

No response

[dbeatty10]

Thanks for reaching out about this @LeoTheGriff !

Can you share more about what specifically you are seeing?

e.g., share a screenshot or a link to a website that highlights what looks incorrect to you.

Also, could you share what steps we can take to see it as well?

[LeoTheGriff]

Apologies, I used a GitHub reporting mechanic that said it would attach the permalink but didn’t. “If a database override is specified, then the resulting database is the default database concatenated with the custom database.” The default macro replaces the default database with custom, it doesn't concat them. https://github.com/dbt-labs/dbt-core/blob/main/core/dbt/include/global_project/macros/get_custom_name/get_custom_database.sql

…

________________________________ From: Doug Beatty ***@***.***> Sent: Monday, November 6, 2023 6:09:18 PM To: dbt-labs/dbt-core ***@***.***> Cc: Leo Griffiths ***@***.***>; Mention ***@***.***> Subject: Re: [dbt-labs/dbt-core] [CT-3322] [Bug] Incorrect behaviour described in docstring for get_custom_database macro. (Issue #9003) Thanks for reaching out about this @LeoTheGriff<https://github.com/LeoTheGriff> ! Can you share more about what specifically you are seeing? e.g., share a screenshot or a link to a website that highlights what looks incorrect to you. Also, could you share what steps we can take to see it as well? — Reply to this email directly, view it on GitHub<#9003 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ACGF7N7JCH3G2EY7PC6FJADYDERU5AVCNFSM6AAAAAA67NSLPWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTOOJVG43TCOJVHA>. You are receiving this because you were mentioned.Message ID: ***@***.***> [CT-3322]: https://dbtlabs.atlassian.net/browse/CT-3322?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ

[LeoTheGriff]

It is a minor fix, I proposed a solution in the linked PR

[dbeatty10]

No prob. Looks like there was copy-paste within #2143 in which the comments didn't get fully updated for accuracy.

Thanks for opening that PR!