-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: get_custom_database docs describe postfix when default behaviour… #9002
fix: get_custom_database docs describe postfix when default behaviour… #9002
Conversation
… is to take the custom database value directly, if provided
Thanks for your pull request, and welcome to our community! We require contributors to sign our Contributor License Agreement and we don't seem to have your signature on file. Check out this article for more information on why we have a CLA. In order for us to review and merge your code, please submit the Individual Contributor License Agreement form attached above above. If you have questions about the CLA, or if you believe you've received this message in error, please reach out through a comment on this PR. CLA has not been signed by users: @LeoTheGriff |
Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide. |
CLA has been signed. |
Thanks for opening this PR @LeoTheGriff ! Looks like there was copy-paste within #2143 in which the comments didn't get fully updated for accuracy. Your update looks good to me. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9002 +/- ##
==========================================
- Coverage 86.51% 86.46% -0.06%
==========================================
Files 179 179
Lines 26508 26508
==========================================
- Hits 22934 22920 -14
- Misses 3574 3588 +14
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Thanks, can this be approved so it can be merged? |
Thanks for finding and fixing this @LeoTheGriff 👍 |
resolves #9003
Problem
Incorrect behaviour described in docstring for get_custom_database macro.
Solution
Update docstring for get_custom_database macro.
Checklist