Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup repo and update readme #1147

Merged
merged 2 commits into from
Dec 13, 2018
Merged

Cleanup repo and update readme #1147

merged 2 commits into from
Dec 13, 2018

Conversation

clrcrl
Copy link
Contributor

@clrcrl clrcrl commented Nov 21, 2018

@drewbanin - early PR for comment.
I'll update the DAG, not sure which is the best project to put in here though

@clrcrl clrcrl changed the title [WIP] Cleanup repo Cleanup repo and update readme Dec 3, 2018
drewbanin
drewbanin approved these changes Dec 3, 2018
View reviewed changes
Copy link
Contributor

@drewbanin drewbanin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! I think this looks great. Let's be sure to update the relevant documentation before merging this. I think some of our current docs point to these samples .yml files, and we should make sure they're pointing elsewhere.

@drewbanin
Copy link
Contributor

you can ignore the build failures here -- i cancelled all of the CI builds since there are no code changes here

@clrcrl
Copy link
Contributor Author

clrcrl commented Dec 11, 2018

Fixes #1065

@clrcrl
Copy link
Contributor Author

clrcrl commented Dec 12, 2018

Have checked the docs for references to sample files and deleted the one remaining reference :)

@clrcrl clrcrl merged commit 3deb295 into dev/grace-kelly Dec 13, 2018
@clrcrl clrcrl deleted the cleanup-repo branch December 13, 2018 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drewbanin drewbanin drewbanin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@clrcrl @drewbanin