-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename default installation directory for packages #3999
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jtcohen6
approved these changes
Oct 5, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had convinced myself this would be tricky, but you've done it brilliantly
…es` from `dbt_modules`. Also rename `module-path` to `packages-install-path` to allow default overrides of package install directory. Deprecation warning added for projects using the old `dbt_modules` name without specifying a `packages-install-path`.
fc87b68
to
0b891de
Compare
emmyoop
added a commit
to dbt-labs/docs.getdbt.com
that referenced
this pull request
Oct 11, 2021
emmyoop
added a commit
to dbt-labs/docs.getdbt.com
that referenced
this pull request
Oct 11, 2021
6 tasks
emmyoop
added a commit
to dbt-labs/docs.getdbt.com
that referenced
this pull request
Oct 13, 2021
iknox-fa
pushed a commit
that referenced
this pull request
Feb 8, 2022
* Change the default dbt packages installation directory to `dbt_packages` from `dbt_modules`. Also rename `module-path` to `packages-install-path` to allow default overrides of package install directory. Deprecation warning added for projects using the old `dbt_modules` name without specifying a `packages-install-path`. * fixed deprecation test bug * Fixed wording on deprecation warning. automatic commit by git-black, original commits: ee5c697
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #3523
Description
dbt_packages
fromdbt_modules
.module-path
topackages-install-path
to make the purpose more clear.dbt_modules
name without specifying apackages-install-path
. Add related deprecation test.Checklist
CHANGELOG.md
and added information about my change to the "dbt next" section.