Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename default installation directory for packages #3999

Merged
merged 3 commits into from
Oct 5, 2021

Conversation

emmyoop
Copy link
Member

@emmyoop emmyoop commented Oct 4, 2021

resolves #3523

Description

  • Change the default dbt packages installation directory to dbt_packages from dbt_modules.
  • Rename module-path to packages-install-path to make the purpose more clear.
  • Add deprecation warning for projects using the old dbt_modules name without specifying a packages-install-path. Add related deprecation test.

Checklist

  • I have signed the CLA
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • I have updated the CHANGELOG.md and added information about my change to the "dbt next" section.

@cla-bot cla-bot bot added the cla:yes label Oct 4, 2021
@emmyoop emmyoop requested review from jtcohen6 and leahwicz October 4, 2021 20:35
Copy link
Contributor

@jtcohen6 jtcohen6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had convinced myself this would be tricky, but you've done it brilliantly

…es` from `dbt_modules`. Also rename `module-path` to `packages-install-path` to allow default overrides of package install directory. Deprecation warning added for projects using the old `dbt_modules` name without specifying a `packages-install-path`.
@emmyoop emmyoop force-pushed the er/3523-rename-dbt-modules branch from fc87b68 to 0b891de Compare October 5, 2021 14:17
@emmyoop emmyoop closed this Oct 5, 2021
@emmyoop emmyoop reopened this Oct 5, 2021
@emmyoop emmyoop merged commit ee5c697 into develop Oct 5, 2021
@emmyoop emmyoop deleted the er/3523-rename-dbt-modules branch October 5, 2021 18:54
emmyoop added a commit to dbt-labs/docs.getdbt.com that referenced this pull request Oct 11, 2021
emmyoop added a commit to dbt-labs/docs.getdbt.com that referenced this pull request Oct 11, 2021
emmyoop added a commit to dbt-labs/docs.getdbt.com that referenced this pull request Oct 13, 2021
iknox-fa pushed a commit that referenced this pull request Feb 8, 2022
* Change the default dbt packages installation directory to `dbt_packages` from `dbt_modules`.  Also rename `module-path` to `packages-install-path` to allow default overrides of package install directory.  Deprecation warning added for projects using the old `dbt_modules` name without specifying a `packages-install-path`.

* fixed deprecation test bug

* Fixed wording on deprecation warning.

automatic commit by git-black, original commits:
  ee5c697
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change the default dbt packages installation directory to dbt_packages from dbt_modules
2 participants