-
Notifications
You must be signed in to change notification settings - Fork 999
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Emmyoop patch 3 #857
Emmyoop patch 3 #857
Conversation
Unsure of where to put changelog entries for each change. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for these updates !!
I left way too many comments. As a general rule:
- Wherever we're documenting The Thing (
model-paths
,seed-properties
, etc), we should include a<Changelog>
item, just calling out that the config/default has been renamed - If we're just updating the name of a file in an example, no big deal, I don't think we need a changelog
- In a bunch of places, the current docs refer to a limited number of places where sources/exposures/properties can be defined. Instead, we should clarify that they can be defined in any resource path, and (in the case of properties) that we highly encourage defining them in the resource path associated with the resource type they're describing. I think it's confusing to call out
model-paths
as an alternative / backwards-compatible option
As soon as you're happy with these docs, we can merge them into the next
branch and deploy them at next.docs.getdbt.com. I'm probably going to merge #836 first, so there will be some conflicting changes to resolve/rebase, namely in the migration guide.
website/docs/tutorial/using-jinja.md
Outdated
@@ -5,7 +5,7 @@ id: "using-jinja" | |||
|
|||
In this tutorial, we're going to take a common pattern used in SQL, and then use Jinja to improve our code. | |||
|
|||
If you'd like to work through this query, add [this CSV](https://github.com/dbt-labs/jaffle_shop/blob/master/data/raw_payments.csv) to the `data/` folder of your dbt project, and then execute `dbt seed`. | |||
If you'd like to work through this query, add [this CSV](https://github.com/dbt-labs/jaffle_shop/blob/HEAD/seeds/raw_payments.csv) to the `seeds/` folder of your dbt project, and then execute `dbt seed`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this will be a broken link until we update the jaffle_shop
repo - what do you think of leaving this as is for now, and leaving ourselves a TODO
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What about linking to the branch where it does exist? https://github.com/dbt-labs/jaffle_shop/blob/core-v1.0.0/seeds/raw_payments.csv
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
that works!
also renamed page and added to redirect
change default from `data` to `seeds` rename page and update _redirects
c6e68f6
to
c28ff23
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for all the hard work to get these right !!
There might be a few stragglers, which we can catch them over the next several weeks — at this point, it feels more important to get the vast majority of the updates in.
Description & motivation
Updating docs for some dbt-core v1.0.0 changes.
dbt-labs/dbt-core#4008
dbt-labs/dbt-core#4007
dbt-labs/dbt-core#3999
To-do before merge
dbt-core v1.0.0 needs to be released
Pre-release docs
Is this change related to an unreleased version of dbt?
next
<Changelog>[New/Changed] in v0.x.0</Changelog>
current
Checklist
Renamed pages:
website/sidebars.js
_redirects