Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mv on_schema_change tests -> "adapter zone" (#6618) #6686

Merged
merged 2 commits into from
Jan 20, 2023

Conversation

colin-rogers-dbt
Copy link
Contributor

  • Mv incremental on_schema_change tests to 'adapter zone'

  • Use type_string()

  • Cleanup

resolves #

Description

Checklist

* Mv incremental on_schema_change tests to 'adapter zone'

* Use type_string()

* Cleanup
@github-actions
Copy link
Contributor

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide.

* Mv incremental on_schema_change tests to 'adapter zone'

* Use type_string()

* Cleanup
@colin-rogers-dbt colin-rogers-dbt added the Skip Changelog Skips GHA to check for changelog file label Jan 20, 2023
Copy link
Contributor

@jtcohen6 jtcohen6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving since dbt-labs/dbt-snowflake#398 was backported to 1.4.latest, and this change is needed so that the test can start succeeding on that branch.

This does represent a net-new addition to dbt-tests-adapter between RC2 and final releases—but no modifications to existing distributed code, and none to dbt-core itself.

@colin-rogers-dbt colin-rogers-dbt merged commit e61a39f into 1.4.latest Jan 20, 2023
@colin-rogers-dbt colin-rogers-dbt deleted the pr6618Backport1.4 branch January 20, 2023 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla:yes Skip Changelog Skips GHA to check for changelog file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants