Make project version Optional #6711

seub · 2023-01-24T18:10:44Z

resolves #6603

Description

I changed Project.version to Optional (default None) in core/dbt/config and core/dbt/contracts.

(This change was suggested by @jtcohen6 in the issue #6603)

This config was not being used by dbt, so I believe no further changes are needed. make test and make integration both passed.

Checklist

I have read the contributing guide and understand what's expected of me
I have signed the CLA
I have run this code in development and it appears to resolve the stated issue
This PR includes tests, or tests are not required/relevant for this PR
I have opened an issue to add/update docs, or docs changes are not required/relevant for this PR
I have run changie new to create a changelog entry

* Add changelog and whitespace fix to version bump Action * Fixing whitespace * Remove tabs * Update .github/workflows/version-bump.yml Co-authored-by: Emily Rockman <emily.rockman@dbtlabs.com> * Update .github/workflows/version-bump.yml Co-authored-by: Emily Rockman <emily.rockman@dbtlabs.com> * Update .github/workflows/version-bump.yml Co-authored-by: Emily Rockman <emily.rockman@dbtlabs.com> * Update .github/workflows/version-bump.yml Co-authored-by: Emily Rockman <emily.rockman@dbtlabs.com> * Updating per comments * Fix whitespace Co-authored-by: Emily Rockman <emily.rockman@dbtlabs.com>

* Python model beta version with update to manifest that renames `raw_sql` and `compiled_sql` to `raw_code` and `compiled_code` Co-authored-by: Jeremy Cohen <jeremy@dbtlabs.com> Co-authored-by: Ian Knox <ian.knox@dbtlabs.com> Co-authored-by: Stu Kilgore <stuart.kilgore@gmail.com>

* Bumping version to 1.3.0b1 and generate CHANGELOG * Update Docker versions for adapters Co-authored-by: Github Build Bot <buildbot@fishtownanalytics.com> Co-authored-by: leahwicz <60146280+leahwicz@users.noreply.github.com>

* [CT-953] [Feature] Support for .csv files when using file selectors(for seed) * Added Changelog entry for issue-5578 * Added Unit tests

* Add defer to docs and compile commands Add docs generate defer test Fix CLA check Add compile defer test * Update changelog * Restore changelog * Add changie entry * Move defer_to_manifest to CompileTask * Add check to to verify defer works as expected * Add assert

* WIP * handle defauly env vars * fix typo * add changelog * small fixes * add constants.py file

* convert to reusable action * fix branch name * reimplemented changelog * update to use workflow * fix typo * move def * inherit secrets * send in comment/label * specify GITHUB_TOKEN * Add automated changelog yaml from template for bot PR * Delete Dependency-20220801-193810.yaml * Add automated changelog yaml from template for bot PR * remove dummy changelog * remove token * rename file * point to main Co-authored-by: Github Build Bot <buildbot@fishtownanalytics.com>

…ate.py (#5604)

…the DAG (#5397) * add Optional node_color config in Docs dataclass * Remove node_color from the original docs config * Add docs config and input validation * Handle when docs is both under docs and config.docs * Add node_color to Docs * Make docs a Dict to avoid parsing errors * Make docs a dataclass instead of a Dict * Fix error when using docs as dataclass * Simplify generator for the default value * skeleton for test fixtures * bump manifest to v7 * + config hierarchy tests * add show override tests * update manifest * Remove node_color from the original docs config * Add node_color to Docs * Make docs a Dict to avoid parsing errors * Make docs a dataclass instead of a Dict * Simplify generator for the default value * + config hierarchy tests * add show override tests * Fix unit tests * Add tests in case of incorrect input for node_color * Rename tests and Fix typos * Fix functional tests * Fix issues with remote branch * Add changie entry * modify tests to meet standards (#5608) Co-authored-by: Matt Winkler <matt.winkler@fishtownanalytics.com> Co-authored-by: Emily Rockman <emily.rockman@dbtlabs.com>

* bring in new index and add changelog * Update Docs-20220804-134138.yaml

* Adding helper functions * adding bad test * use ResolvedMetricReference * adding pytest * adding changie updates * adding pre-commit changes Co-authored-by: Chenyu Li <chenyu.li@dbtlabs.com>

* first pass * tweaks * convert to use dbt-docs links in contributors section * fix eq check * fix format of contributos prs * update docs changelog to point back to dbt-docs * update beta 1.3 docs changelog * remove optional param * make issue inclusion conditional on being filled

* Fix postgres handling for unlimited varchars * fix: correctly name varchar * chore: added changelog entry * Update .changes/unreleased/Fixes-20220523-103843.yaml Co-authored-by: Emily Rockman <ebuschang@gmail.com> Co-authored-by: Emily Rockman <ebuschang@gmail.com>

* Pass patch_config_dict to build_config_dict when creating unrendered_config * Add test case for unrendered_config * Changie * formatting, fix test * Fix test so unrendered config includes docs config

* Use sys.exit instead of exit * Add changelog

* show reason for schema change failures When the incremental model fails, I do not get the context I need to easily fix my discrepency. Adding more info * Update on_schema_change.sql Fix identation * Added changie changes Added changie changes * Update on_schema_change.sql Trim whitespaces * Update on_schema_change.sql Log message text enhancement

* Only consider schema change when column cannot be expanded * Add test for column shortening * Add changelog entry * Move test from integration to adapter tests * Remove print statement * add on_schema_change

Print more information on log line interop test failures

* fix multiple args for ref and source * add test for support multi part ref and source

* Change postgres name truncation logic to be overridable. Add exception with debugging instructions. * Add changelog. Co-authored-by: Mila Page <versusfacit@users.noreply.github.com>

* First cut at checking version compat for hub pkgs * Account for field rename * Add changelog entry * Update error message * Fix unit test * PR feedback * Try fixing test * Edit exception msg * Expand unit test to include pkg prerelease * Update core/dbt/deps/registry.py Co-authored-by: Doug Beatty <44704949+dbeatty10@users.noreply.github.com> Co-authored-by: Doug Beatty <44704949+dbeatty10@users.noreply.github.com>

* Run black + flake8 on tests dir * Run pre-commit

* Convert partial parsing tests * reformat

* Refactor "set_connection_name" to properly handle reused connection * Update test * Changie * Limit test of ConnectionUsed events to non-Windows

…ore/dbt/contracts

cla-bot · 2023-01-24T18:10:47Z

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Brice Loustau.
This is most likely caused by a git client misconfiguration; please make sure to:

check if your git client is configured with an email to sign commits git config --list | grep email
If not, set it up using git config --global user.email email@example.com
Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

cla-bot · 2023-01-24T18:27:59Z

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Brice Loustau.
This is most likely caused by a git client misconfiguration; please make sure to:

check if your git client is configured with an email to sign commits git config --list | grep email
If not, set it up using git config --global user.email email@example.com
Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

cla-bot · 2023-01-24T20:11:03Z

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Brice Loustau.
This is most likely caused by a git client misconfiguration; please make sure to:

check if your git client is configured with an email to sign commits git config --list | grep email
If not, set it up using git config --global user.email email@example.com
Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

seub · 2023-01-24T20:15:10Z

I fixed my email in the last (empty) commit, so the cla-bot must be triggered by the first two commits. But I don't think I can change them now.

jtcohen6 · 2023-01-24T20:39:38Z

@seub Could you try git rebase, to squash your previous commits together?

cla-bot · 2023-01-24T21:30:31Z

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Leo Folsom.
This is most likely caused by a git client misconfiguration; please make sure to:

check if your git client is configured with an email to sign commits git config --list | grep email
If not, set it up using git config --global user.email email@example.com
Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

seub · 2023-01-24T21:34:20Z

I rewrote the email in the faulty commits using this and then I did git push -f. But clearly something is not working. I'll just close this MR and create a new one.

seub · 2023-01-24T21:57:00Z

New PR: #6718

leahwicz and others added 30 commits July 28, 2022 14:08

add changelog from dbt-docs (#5577)

610b37d

add info on basics of using actions (#5576)

746154e

use MethodName.File when value ends with .py (#5295)

890fe37

fix passing in Rlock error in rpc (#5580)

cc95944

Bumping version to 1.3.0b1 and generate changelog (#5582)

892f62f

* Bumping version to 1.3.0b1 and generate CHANGELOG * Update Docker versions for adapters Co-authored-by: Github Build Bot <buildbot@fishtownanalytics.com> Co-authored-by: leahwicz <60146280+leahwicz@users.noreply.github.com>

Convert git deps to local, faster tests (#5515)

86def2d

use MethodName.File when value ends with .csv (#5581)

0cd4b4b

* [CT-953] [Feature] Support for .csv files when using file selectors(for seed) * Added Changelog entry for issue-5578 * Added Unit tests

rename .github readme (#5597)

de26c9c

Store when default env vars are used in manifest (#5589)

30daef1

* WIP * handle defauly env vars * fix typo * add changelog * small fixes * add constants.py file

Comment out line to generate new manifest in test_previous_version_st…

410750e

…ate.py (#5604)

bring in new index and add changelog (#5614)

6a7c257

* bring in new index and add changelog * Update Docs-20220804-134138.yaml

Do not render metrics description field when doing render_data (#5603)

bf88b62

Adding Metric Helper Functions (#5607)

eab8b83

* Adding helper functions * adding bad test * use ResolvedMetricReference * adding pytest * adding changie updates * adding pre-commit changes Co-authored-by: Chenyu Li <chenyu.li@dbtlabs.com>

CT-729 Include schema model config in unrendered config (#5344)

1ad3eec

* Pass patch_config_dict to build_config_dict when creating unrendered_config * Add test case for unrendered_config * Changie * formatting, fix test * Fix test so unrendered config includes docs config

Use sys.exit instead of exit (#5627)

95f0806

* Use sys.exit instead of exit * Add changelog

Extended validations for the project names (#5620)

8c5952e

Fix/incremental column precision changes (#5395)

59b5441

* Only consider schema change when column cannot be expanded * Add test for column shortening * Add changelog entry * Move test from integration to adapter tests * Remove print statement * add on_schema_change

Print more information on log line interop test failures (#5659)

5a290ac

Print more information on log line interop test failures

fix multiple args for ref and source (#5635)

ae988bb

* fix multiple args for ref and source * add test for support multi part ref and source

Change postgres name truncation logic to be overridable. (#5656)

b421122

* Change postgres name truncation logic to be overridable. Add exception with debugging instructions. * Add changelog. Co-authored-by: Mila Page <versusfacit@users.noreply.github.com>

Update "Homepage" link for dbt-tests-adapter on PyPI (#5678)

19fb2d2

ChenyuLInx and others added 9 commits January 12, 2023 16:05

convert adapter table materialization test (#6595)

866f75d

converting 022_test_timezones (#6588)

3ea381a

migrate ref override (#6600)

2d21122

convert 037_external_references (#6589)

d1f0cda

convert 057_run_query_tests (#6607)

1cdbe5b

Reformat tests/ (#6622)

f05679d

* Run black + flake8 on tests dir * Run pre-commit

Convert 068_partial_parsing_tests (#6614)

da8f1fa

* Convert partial parsing tests * reformat

CT 1440 Fix code to emit ConnectionReused event (#6605)

c36405f

* Refactor "set_connection_name" to properly handle reused connection * Update test * Changie * Limit test of ConnectionUsed events to non-Windows

Made Project.version Optional (default None) in core/dbt/config and c…

f1aeb4e

…ore/dbt/contracts

seub requested a review from a team as a code owner January 24, 2023 18:10

seub requested a review from gshank January 24, 2023 18:10

Changie

e24ece3

seub requested a review from a team as a code owner January 24, 2023 18:27

seub requested a review from nathaniel-may January 24, 2023 18:27

This was referenced Jan 24, 2023

version optional in dbt_project.yml dbt-labs/docs.getdbt.com#2747

Closed

[CT-1815] [Feature] Remove required 'version' from dbt_project.yml #6603

Closed

Fixed email config

a801f9d

seub requested a review from a team as a code owner January 24, 2023 21:30

seub requested a review from a team January 24, 2023 21:30

seub requested a review from leahwicz as a code owner January 24, 2023 21:30

seub closed this Jan 24, 2023

seub mentioned this pull request Jan 24, 2023

Made project version optional (default None) #6718

Merged

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Make project version Optional #6711

Make project version Optional #6711

seub commented Jan 24, 2023 •

edited

Loading

cla-bot bot commented Jan 24, 2023

cla-bot bot commented Jan 24, 2023

cla-bot bot commented Jan 24, 2023

seub commented Jan 24, 2023

jtcohen6 commented Jan 24, 2023

cla-bot bot commented Jan 24, 2023

seub commented Jan 24, 2023 •

edited

Loading

seub commented Jan 24, 2023

Make project version Optional #6711

Make project version Optional #6711

Conversation

seub commented Jan 24, 2023 • edited Loading

Description

Checklist

cla-bot bot commented Jan 24, 2023

cla-bot bot commented Jan 24, 2023

cla-bot bot commented Jan 24, 2023

seub commented Jan 24, 2023

jtcohen6 commented Jan 24, 2023

cla-bot bot commented Jan 24, 2023

seub commented Jan 24, 2023 • edited Loading

seub commented Jan 24, 2023

seub commented Jan 24, 2023 •

edited

Loading

seub commented Jan 24, 2023 •

edited

Loading