Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace dbt/common with dbt-common #9342

Merged
merged 15 commits into from
Jan 12, 2024
Merged

Conversation

MichelleArk
Copy link
Contributor

@MichelleArk MichelleArk commented Jan 5, 2024

resolves #9357

Problem

The contents of dbt/common are being moved to dbt-common, so we can now delete dbt/common and its associated tests/dependencies!

Solution

  • Delete dbt/common
  • Delete tests/unit/common
  • Add dbt-common to setup.py (as a GH dependency until release process for dbt-common is ironed out)
  • Remove any dependencies / third party stubs that are no longer necessary once dbt/common is moved out

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc) or this PR has already received feedback and approval from Product or DX
  • This PR includes type annotations for new and modified functions

@cla-bot cla-bot bot added the cla:yes label Jan 5, 2024
Copy link
Contributor

github-actions bot commented Jan 5, 2024

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide.

Copy link

codecov bot commented Jan 5, 2024

Codecov Report

Attention: 38 lines in your changes are missing coverage. Please review.

Comparison is base (cff0b65) 86.65% compared to head (fa5aa42) 87.08%.

Files Patch % Lines
core/dbt/adapters/base/connections.py 28.57% 10 Missing ⚠️
core/dbt/contracts/graph/manifest.py 50.00% 7 Missing ⚠️
core/dbt/adapters/sql/connections.py 63.63% 4 Missing ⚠️
core/dbt/task/base.py 55.55% 4 Missing ⚠️
core/dbt/task/sql.py 0.00% 4 Missing ⚠️
core/dbt/contracts/sql.py 0.00% 3 Missing ⚠️
core/dbt/adapters/base/relation.py 50.00% 2 Missing ⚠️
core/dbt/task/debug.py 83.33% 2 Missing ⚠️
core/dbt/task/docs/generate.py 85.71% 1 Missing ⚠️
core/dbt/task/init.py 80.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9342      +/-   ##
==========================================
+ Coverage   86.65%   87.08%   +0.43%     
==========================================
  Files         230      184      -46     
  Lines       27060    23937    -3123     
==========================================
- Hits        23448    20846    -2602     
+ Misses       3612     3091     -521     
Flag Coverage Δ
integration 84.42% <90.92%> (+0.88%) ⬆️
unit 63.89% <79.13%> (-1.37%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Comment on lines -67 to -70
"colorama>=0.3.9,<0.5",
"pathspec>=0.9,<0.12",
"isodate>=0.6,<0.7",
# ----
Copy link
Member

@emmyoop emmyoop Jan 9, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

colorama and isodate moved to dbt-common!

core/setup.py Outdated Show resolved Hide resolved
core/setup.py Outdated Show resolved Hide resolved
@MichelleArk MichelleArk marked this pull request as ready for review January 11, 2024 16:56
@MichelleArk MichelleArk requested review from a team as code owners January 11, 2024 16:56
@QMalcolm
Copy link
Contributor

9k lines deleted, niiiiice ❤️

@MichelleArk MichelleArk merged commit 00f4a25 into main Jan 12, 2024
51 checks passed
@MichelleArk MichelleArk deleted the add-dbt-common-requirement branch January 12, 2024 15:19
@emmyoop emmyoop restored the add-dbt-common-requirement branch January 12, 2024 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CT-3538] [Adapter Decoupling] Add dbt-common as dependency and remove dbt/common subdir
5 participants