Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "replace dbt/common with dbt-common" #9365

Merged
merged 1 commit into from
Jan 12, 2024

Conversation

MichelleArk
Copy link
Contributor

Reverts #9342

Noticed some downstream breakage due to dbt.logger removal

Copy link
Contributor

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide.

@MichelleArk MichelleArk added the Skip Changelog Skips GHA to check for changelog file label Jan 12, 2024
Copy link

codecov bot commented Jan 12, 2024

Codecov Report

Attention: 556 lines in your changes are missing coverage. Please review.

Comparison is base (00f4a25) 87.06% compared to head (a0e36bf) 86.62%.

Files Patch % Lines
core/dbt/logger.py 61.23% 119 Missing ⚠️
core/dbt/common/clients/system.py 66.78% 93 Missing ⚠️
core/dbt/common/events/types_pb2.py 21.05% 45 Missing ⚠️
core/dbt/common/exceptions/macros.py 52.30% 31 Missing ⚠️
core/dbt/common/clients/jinja.py 89.73% 27 Missing ⚠️
core/dbt/common/semver.py 90.45% 27 Missing ⚠️
core/dbt/common/exceptions/base.py 86.54% 23 Missing ⚠️
core/dbt/common/contracts/config/base.py 88.38% 18 Missing ⚠️
core/dbt/common/clients/_jinja_blocks.py 92.02% 15 Missing ⚠️
core/dbt/common/utils/encoding.py 61.11% 14 Missing ⚠️
... and 27 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9365      +/-   ##
==========================================
- Coverage   87.06%   86.62%   -0.45%     
==========================================
  Files         184      230      +46     
  Lines       23937    27060    +3123     
==========================================
+ Hits        20841    23441    +2600     
- Misses       3096     3619     +523     
Flag Coverage Δ
integration 83.51% <79.04%> (-0.83%) ⬇️
unit 65.25% <76.12%> (+1.36%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MichelleArk MichelleArk merged commit a1f78a8 into main Jan 12, 2024
58 of 61 checks passed
@MichelleArk MichelleArk deleted the revert-9342-add-dbt-common-requirement branch January 12, 2024 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla:yes Skip Changelog Skips GHA to check for changelog file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants