Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CI trigger to run off forks #329

Merged
merged 1 commit into from
Dec 6, 2024
Merged

Update CI trigger to run off forks #329

merged 1 commit into from
Dec 6, 2024

Conversation

emmyoop
Copy link
Member

@emmyoop emmyoop commented Dec 6, 2024

Same issue as dbt-labs/dbt-utils#971

Problem

PRs from forks will fail CI because the PR trigger is pull_request so they do not have access to teh repo vars that are needed since the workflow runs in the context of the fork.

Solution

Update to trigger off pull_request_target and the workflow runs in the context of the base branch (this repo).

Will not require a release as this only affects local repo CI.

@emmyoop emmyoop requested a review from jeremyyeo as a code owner December 6, 2024 16:14
@emmyoop emmyoop requested a review from dataders December 6, 2024 16:21
Copy link
Contributor

@dbeatty10 dbeatty10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @emmyoop 🚀 !

@dbeatty10 dbeatty10 merged commit ce4751e into main Dec 6, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants