Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CI trigger to run off forks #518

Merged
merged 1 commit into from
Dec 6, 2024
Merged

Update CI trigger to run off forks #518

merged 1 commit into from
Dec 6, 2024

Conversation

emmyoop
Copy link
Member

@emmyoop emmyoop commented Dec 6, 2024

This is a:

  • bug fix PR with no breaking changes
  • new functionality

Link to Issue

Same issue as dbt-labs/dbt-utils#971

Description & motivation

PRs from forks will fail CI because the PR trigger is pull_request so they do not have access to teh repo vars that are needed since the workflow runs in the context of the fork.

Update to trigger off pull_request_target and the workflow runs in the context of the base branch (this repo).

Will not require a release as this only affects local repo CI.

Checklist

  • I have verified that these changes work locally on the following warehouses (Note: it's okay if you do not have access to all warehouses, this helps us understand what has been covered)
    • BigQuery
    • Postgres
    • Redshift
    • Snowflake
    • Databricks
    • DuckDB
    • Trino/Starburst
  • I have updated the README.md (if applicable)
  • I have added tests & descriptions to my models (and macros if applicable)

@emmyoop emmyoop merged commit de19fa9 into main Dec 6, 2024
2 checks passed
@emmyoop emmyoop deleted the er/update-trigger branch December 6, 2024 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants