using string interpoloation to gather correct pointer for dbt-core te… #80

McKnight-42 · 2022-03-11T20:23:54Z

resolves #77

Description

adds github action itenterpoloation

NOTE: possible issue to fix later on in cases of pushing to none main or latest branches. ex feature branches

Checklist

I have signed the CLA
I have run this code in development and it appears to resolve the stated issue
This PR includes tests, or tests are not required/relevant for this PR
I have updated the CHANGELOG.md and added information about my change to the "dbt-redshift next" section.

* Slack message for failed nightly runs (#41) * Add Redshift parameter to create tables with backup option specified (#42) * Update impl and adapters to support backup parameter * Add test files * Add test files * Add PR link to Changelog * Add EOF newlines * Debug and split test into two separate cases * Add contributor info Co-authored-by: Jeremy Cohen <jeremy@dbtlabs.com> * Bumping version to 1.0.0rc2 (#45) * Bumping version to 1.0.0rc2 * Update changelog Co-authored-by: Github Build Bot <buildbot@fishtownanalytics.com> Co-authored-by: Jeremy Cohen <jeremy@dbtlabs.com> Co-authored-by: Dan Bryan <dlb8685@gmail.com> Co-authored-by: Jeremy Cohen <jeremy@dbtlabs.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Github Build Bot <buildbot@fishtownanalytics.com>

* Bumping version to 1.0.0 (#47) Co-authored-by: Github Build Bot <buildbot@fishtownanalytics.com> * Update CHANGELOG.md Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Github Build Bot <buildbot@fishtownanalytics.com>

…sts against release branches

…ranch against

.github/workflows/main.yml

…om:dbt-labs/dbt-redshift into mcknight/fix_gha_for_adapter_releases

McKnight-42 · 2022-03-14T19:49:06Z

Tests pass when we change pull_request_target to pull_request to go around some of our strict gha testing workflows.

.github/workflows/integration.yml

VersusFacit

couple small comments. Slack me and I'll prioritize a rereview.

CHANGELOG.md

tests/integration/backup_table_tests/test_backup_table_option.py

.github/workflows/main.yml

tests/integration/backup_table_tests/test_backup_table_option.py

CHANGELOG.md

leahwicz · 2022-03-21T16:38:40Z

.github/workflows/main.yml

      - name: Install python dependencies
        run: |
          pip install  --user --upgrade pip
          pip install tox
          pip --version
          tox --version

-      - name: Install dbt-core latest
+      - name: Install dbt-core from branch ${{ steps.dbt-core-version.outputs.dbt-version.dbt-core-ref }}


Suggested change

- name: Install dbt-core from branch ${{ steps.dbt-core-version.outputs.dbt-version.dbt-core-ref }}

- name: Install dbt-core from branch ${{ steps.dbt-core-version.outputs.dbt-version }}

I don't think you need the dbt-core-ref anymore do you?

name change was based on suggestion by @kwigley in earlier comments #80 (comment)

I see. I think the problem here is the name change only happens in single place (the install step name) but nowhere else. That variable is not set to anything so it is blank.

Also the name change should remove dbt-version then and not just append to it:
Original name: steps.dbt-core-version.outputs.dbt-version
Suggested name: steps.dbt-core-version.outputs.dbt-core-ref
What is here: steps.dbt-core-version.outputs.dbt-version.dbt-core-ref

Name change modified in steps description, postgres section and steps to all be assigned same.

.github/workflows/integration.yml

…e iof where version is coming from

…om:dbt-labs/dbt-redshift into mcknight/fix_gha_for_adapter_releases

leahwicz

Looks good! Thanks Matt!

* backporting #80 to unstick releases for adapters * updating dev_requirements and commenting out lines in main.yaml * adding backport of pr#58 to get rid of testing error based on pr #4512 in dbt-core * uncommenting to see if we can make pointers of local install and tox install the same * testing if tox change is all thats needed * tests failed proving the addition is needed as backport #58 * trying out removal of dbt-core-ref install * remove white-space * remove whitespace * remove trailing whitespace on main.yml

@VersusFacit

dbt-labs#80) * Merge `main` into `1.0.latest` (dbt-labs#46) * Slack message for failed nightly runs (dbt-labs#41) * Add Redshift parameter to create tables with backup option specified (dbt-labs#42) * Update impl and adapters to support backup parameter * Add test files * Add test files * Add PR link to Changelog * Add EOF newlines * Debug and split test into two separate cases * Add contributor info Co-authored-by: Jeremy Cohen <jeremy@dbtlabs.com> * Bumping version to 1.0.0rc2 (dbt-labs#45) * Bumping version to 1.0.0rc2 * Update changelog Co-authored-by: Github Build Bot <buildbot@fishtownanalytics.com> Co-authored-by: Jeremy Cohen <jeremy@dbtlabs.com> Co-authored-by: Dan Bryan <dlb8685@gmail.com> Co-authored-by: Jeremy Cohen <jeremy@dbtlabs.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Github Build Bot <buildbot@fishtownanalytics.com> * [Backport] Bumping version to 1.0.0 (dbt-labs#47) (dbt-labs#48) * Bumping version to 1.0.0 (dbt-labs#47) Co-authored-by: Github Build Bot <buildbot@fishtownanalytics.com> * Update CHANGELOG.md Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Github Build Bot <buildbot@fishtownanalytics.com> * Fix package version (dbt-labs#49) * using string interpoloation to gather correct pointer for dbt-core tests against release branches * created new job for gha to grab correct version of dbt-core to test branch against * minor update * adding Get dbt-core-version step to integration.yaml * modifying version parameters * change for integration testing * updating file * readding pull_request_target now that tests pass * make nit: suggested changes * testing conditional logic in integration.yml * updating test names * creating main.yml versions of new condtional steps for dbt-version gather * trying different version of test v.2 * v.3 of conditional mix of original version of tests and leah logic * adding comment and changelog entry * changes made after review by @VersusFacit and @kwigley * name change * minor updates * updating name of version ref * name change of dbt-version step to dbt-core-ref to be more descriptive iof where version is coming from * Update test_backup_table_option.py * Update test_backup_table_option.py * reseting file that shouldn't of been changed Co-authored-by: leahwicz <60146280+leahwicz@users.noreply.github.com> Co-authored-by: Dan Bryan <dlb8685@gmail.com> Co-authored-by: Jeremy Cohen <jeremy@dbtlabs.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Github Build Bot <buildbot@fishtownanalytics.com>

leahwicz and others added 3 commits December 3, 2021 13:54

Fix package version (#49)

58efd83

cla-bot bot added the cla:yes label Mar 11, 2022

McKnight-42 changed the base branch from main to 1.0.latest March 11, 2022 20:26

using string interpoloation to gather correct pointer for dbt-core te…

5571085

…sts against release branches

McKnight-42 force-pushed the mcknight/fix_gha_for_adapter_releases branch from 4b7b12f to 5571085 Compare March 11, 2022 20:31

created new job for gha to grab correct version of dbt-core to test b…

c318e41

…ranch against

kwigley reviewed Mar 11, 2022

View reviewed changes

.github/workflows/main.yml Outdated Show resolved Hide resolved

McKnight-42 changed the base branch from 1.0.latest to main March 11, 2022 21:44

McKnight-42 changed the base branch from main to 1.0.latest March 11, 2022 21:46

minor update

d1a04d0

McKnight-42 marked this pull request as ready for review March 11, 2022 21:55

McKnight-42 changed the base branch from 1.0.latest to main March 11, 2022 21:55

McKnight-42 changed the base branch from main to 1.0.latest March 11, 2022 21:59

McKnight-42 changed the base branch from 1.0.latest to main March 11, 2022 22:04

Merge branch 'main' into mcknight/fix_gha_for_adapter_releases

5a50ae5

McKnight-42 requested a review from kwigley March 11, 2022 22:12

McKnight-42 changed the base branch from main to 1.0.latest March 11, 2022 22:16

adding Get dbt-core-version step to integration.yaml

f21bc6f

McKnight-42 changed the base branch from 1.0.latest to main March 11, 2022 22:50

McKnight-42 added 5 commits March 11, 2022 16:50

Merge branch 'mcknight/fix_gha_for_adapter_releases' of gist.github.c…

fea3667

…om:dbt-labs/dbt-redshift into mcknight/fix_gha_for_adapter_releases

modifying version parameters

bac8f96

change for integration testing

7886109

updating file

d54ef1d

readding pull_request_target now that tests pass

b6afaa5

McKnight-42 requested a review from VersusFacit March 14, 2022 19:55

leahwicz reviewed Mar 18, 2022

View reviewed changes

.github/workflows/integration.yml Outdated Show resolved Hide resolved

leahwicz reviewed Mar 18, 2022

View reviewed changes

.github/workflows/integration.yml Outdated Show resolved Hide resolved

McKnight-42 requested a review from leahwicz March 18, 2022 19:14

trying different version of test v.2

64847f0

McKnight-42 self-assigned this Mar 18, 2022

McKnight-42 added 2 commits March 18, 2022 14:39

v.3 of conditional mix of original version of tests and leah logic

dade718

adding comment and changelog entry

b5c38ea

VersusFacit reviewed Mar 18, 2022

View reviewed changes

CHANGELOG.md Outdated Show resolved Hide resolved

tests/integration/backup_table_tests/test_backup_table_option.py Outdated Show resolved Hide resolved

.github/workflows/main.yml Outdated Show resolved Hide resolved

McKnight-42 added 2 commits March 19, 2022 01:02

changes made after review by @VersusFacit and @kwigley

bfe69d7

name change

d19a374

McKnight-42 requested a review from VersusFacit March 21, 2022 06:21