Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mcknight/backport 58 #89

Merged
merged 10 commits into from
Mar 25, 2022
Merged

Mcknight/backport 58 #89

merged 10 commits into from
Mar 25, 2022

Conversation

McKnight-42
Copy link
Contributor

@McKnight-42 McKnight-42 commented Mar 24, 2022

Description

1.Testing in pulling in pr #58 will fix testing error in back port on 1.0.latest.
2. Looking at ways to control tox dbt-core install (currently hardcoded in dev_requirements)

Checklist

  • I have signed the CLA
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • I have updated the CHANGELOG.md and added information about my change to the "dbt-redshift next" section.

@cla-bot cla-bot bot added the cla:yes label Mar 24, 2022
@McKnight-42
Copy link
Contributor Author

McKnight-42 commented Mar 25, 2022

rough ideas to control pointer for dev_requirements. create a github action that updates pointer.
positives:

  • could be used for all branches main

Negatives:

  • extra github action
  • potential issue with having to recommit the change?
  • potentially a pain to pass variable to text file

https://github.saobby.my.eu.orgmunity/t/can-github-actions-directly-edit-files-in-a-repository/17884

@McKnight-42 McKnight-42 marked this pull request as ready for review March 25, 2022 19:19
@McKnight-42 McKnight-42 requested a review from kwigley March 25, 2022 19:25
@McKnight-42 McKnight-42 self-assigned this Mar 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants