Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ADAP-539] [Bug] Remove dead code 💀 #758

Closed
2 tasks done
Fokko opened this issue May 10, 2023 · 3 comments · Fixed by #759
Closed
2 tasks done

[ADAP-539] [Bug] Remove dead code 💀 #758

Fokko opened this issue May 10, 2023 · 3 comments · Fixed by #759
Labels
bug Something isn't working

Comments

@Fokko
Copy link
Contributor

Fokko commented May 10, 2023 •
edited
Loading

Is this a new bug in dbt-spark?

  • I believe this is a new bug in dbt-spark
  • I have searched the existing issues, and I could not find an existing issue for this bug

Current Behavior

I noticed that there is quite a bit of dead code in the repository. I would like to clean this up. I didn't want to do this in another ticket, because that would introduce a lot of unrelated changes

Expected Behavior

Don't see any code in the codebase that is never used.
@Fokko Fokko added bug Something isn't working triage labels May 10, 2023
@github-actions github-actions bot changed the title [Bug] Remove dead code 💀 [ADAP-539] [Bug] Remove dead code 💀 May 10, 2023
Fokko added a commit to Fokko/dbt-spark that referenced this issue May 10, 2023
@Fokko
Remove dead code 💀
e28fe39 
Resolves dbt-labs#758
@Fokko Fokko mentioned this issue May 10, 2023
Merged
6 tasks
Fokko added a commit to Fokko/dbt-spark that referenced this issue May 10, 2023
@Fokko
Remove dead code 💀
fd8e017 
Resolves dbt-labs#758
@dbeatty10
Copy link
Contributor

Less code is more!

Thanks for opening this and the related PR @Fokko !

@dbeatty10 dbeatty10 removed the triage label May 10, 2023
@Fokko
Copy link
Contributor Author

Fokko commented May 10, 2023

@dbeatty10 And thank you for the quick response today and yesterday, appreciate it! 👍🏻

@dbeatty10
Copy link
Contributor

You are very welcome @Fokko ! ❤️

Fokko added a commit to Fokko/dbt-spark that referenced this issue May 10, 2023
@Fokko
Remove dead code 💀
4376893 
Resolves dbt-labs#758
Fokko added a commit to Fokko/dbt-spark that referenced this issue May 10, 2023
@Fokko
Remove dead code 💀
bf9bd19 
Resolves dbt-labs#758
mikealfare added a commit that referenced this issue May 12, 2023
@Fokko @mikealfare
Remove dead code 💀 (#759)
5ebff0d 
Resolves #758

Co-authored-by: Mike Alfare <13974384+mikealfare@users.noreply.github.com>
MichelleArk pushed a commit that referenced this issue May 12, 2023
@Fokko @mikealfare @MichelleArk
Remove dead code 💀 (#759)
cf3a1ad 
Resolves #758

Co-authored-by: Mike Alfare <13974384+mikealfare@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove dead code 💀 Fokko/dbt-spark
2 participants
@Fokko @dbeatty10