Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dead code 💀 #759

Merged
merged 2 commits into from
May 12, 2023
Merged

Remove dead code 💀 #759

merged 2 commits into from
May 12, 2023

Conversation

Fokko
Copy link
Contributor

@Fokko Fokko commented May 10, 2023

Resolves #758 Less code is more!

Description

Checklist

@Fokko Fokko requested a review from a team as a code owner May 10, 2023 13:47
@Fokko Fokko requested a review from mikealfare May 10, 2023 13:47
@cla-bot cla-bot bot added the cla:yes label May 10, 2023
@Fokko Fokko force-pushed the fd-remove-dead-code branch from e28fe39 to fd8e017 Compare May 10, 2023 13:48
@dbeatty10 dbeatty10 added the ready_for_review Externally contributed PR has functional approval, ready for code review from Core engineering label May 10, 2023
@mikealfare
Copy link
Contributor

Two sets of integration tests didn't run for some reason. I kicked them off again in CircleCI.

@Fokko
Copy link
Contributor Author

Fokko commented May 10, 2023

@mikealfare Thanks for re-running. Looks like there are some issues with Github Actions right now.

@mikealfare
Copy link
Contributor

@mikealfare Thanks for re-running. Looks like there are some issues with Github Actions right now.

'tis a weekday after all

@Fokko
Copy link
Contributor Author

Fokko commented May 10, 2023

Hmm, doesn't look directly related to me:

Invoking dbt with ['run']
21:24:31  Running with dbt=1.6.0-a1
21:24:31  Found 2 models, 0 tests, 0 snapshots, 0 analyses, 356 macros, 0 operations, 1 seed file, 0 sources, 0 exposures, 0 metrics, 0 groups
21:24:31  
21:24:34  Concurrency: 1 threads (target='default')
21:24:34  
21:24:34  1 of 2 START sql incremental model test16837538613394426772_test_persist_docs.incremental_delta_model  [RUN]
21:24:38  1 of 2 ERROR creating sql incremental model test16837538613394426772_test_persist_docs.incremental_delta_model  [ERROR in 3.79s]
21:24:38  2 of 2 START sql table model test16837538613394426772_test_persist_docs.table_delta_model  [RUN]
21:24:43  2 of 2 OK created sql table model test16837538613394426772_test_persist_docs.table_delta_model  [OK in 4.44s]
21:24:43  
21:24:43  Finished running 1 incremental model, 1 table model in 0 hours 0 minutes and 12.01 seconds (12.01s).
21:24:43  
21:24:43  Completed with 1 error and 0 warnings:
21:24:43  
21:24:43  Runtime Error in model incremental_delta_model (models/incremental_delta_model.sql)
21:24:43    ('42000', '[42000] [Simba][Hardy] (80) Syntax or semantic analysis error thrown in server while executing query. Error message from server: org.apache.hive.service.cli.HiveSQLException: Error running query: [_LEGACY_ERROR_TEMP_DBR_0210] org.apache.spark.sql.AnalysisException: org.apache.hadoop.hive.ql.metadata.HiveException: at least one column must be specified for the table\n\tat org.apache.s (80) (SQLExecDirectW)')
21:24:43  
21:24:43  Done. PASS=1 WARN=0 ERROR=1 SKIP=0 TOTAL=2

@Fokko Fokko force-pushed the fd-remove-dead-code branch from fd8e017 to 4376893 Compare May 10, 2023 21:52
@Fokko Fokko force-pushed the fd-remove-dead-code branch from 4376893 to bf9bd19 Compare May 10, 2023 21:57
@Fokko
Copy link
Contributor Author

Fokko commented May 10, 2023

@mikealfare Happy CI :)

@mikealfare
Copy link
Contributor

@nssalian Can you take a quick look at this? I don't see any issue with removing the code since all the CI checks are passing. But is there a chance that Databricks is using some of this code?

@mikealfare mikealfare merged commit 5ebff0d into dbt-labs:main May 12, 2023
MichelleArk pushed a commit that referenced this pull request May 12, 2023
Resolves #758

Co-authored-by: Mike Alfare <13974384+mikealfare@users.noreply.github.com>
@Fokko Fokko deleted the fd-remove-dead-code branch May 14, 2023 19:46
@Fokko
Copy link
Contributor Author

Fokko commented May 14, 2023

Thanks for merging @mikealfare appreciate the quick follow up

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla:yes ready_for_review Externally contributed PR has functional approval, ready for code review from Core engineering
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ADAP-539] [Bug] Remove dead code 💀
3 participants