Initial attempt to get spark working with new testing framework #299
Conversation
|
Nice work! Just in case you didn't see, the currently failing test is because dbt-spark/tests/specs/spark-thrift.dbtspec Lines 20 to 22 in d7f1d38 The other connection methods (Databricks) are running Spark v3, which does |
|
The spark thrift one was the one I tested locally, and that test passed :). So I'm guessing locally we're using a different Spark version? I'll mark that test as a skip though. |
gshank
force-pushed
the
ct-360-new_test_framework_spark
branch
from
ab54007 to
ca07af1
Compare
gshank
force-pushed
the
ct-360-new_test_framework_spark
branch
from
ca07af1 to
a00272e
Compare
|
Hi Gerda the test you have failing for odbc cluster may be due to not having this change implemented #301. at least thats my best guess off the error thats being thrown. |
| @@ -4,8 +4,8 @@ | |||
| from pathlib import Path | |||
|
|
|||
|
|
|||
| TestResults = namedtuple( | |||
| 'TestResults', | |||
| ResultHolder = namedtuple( | |||
There was a problem hiding this comment.
Haha I actually suggested Matt to convert this to the same name
There was a problem hiding this comment.
I saw that and used the same name :). Pytest was also trying to collect "TestResults" as a test class too.
| @@ -77,6 +77,8 @@ def __init__(self): | |||
|
|
|||
|
|
|||
| class TestArgs: | |||
| __test__ = False | |||
There was a problem hiding this comment.
Why does this line fix the tests?
There was a problem hiding this comment.
pytest test collection gathers up all classes that start with 'Test', so the test = False marks this class as "not a test".
### Description Port testing framework changes from dbt-labs/dbt-spark#299 and dbt-labs/dbt-spark#314.
resolves #298
Description
Initial implementation of new testing framework in Spark
Checklist
CHANGELOG.mdand added information about my change to the "dbt-spark next" section.