Initial attempt to get spark working with new testing framework #299
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,10 @@ | ||
| [pytest] | ||
| filterwarnings = | ||
| ignore:.*'soft_unicode' has been renamed to 'soft_str'*:DeprecationWarning | ||
| ignore:unclosed file .*:ResourceWarning | ||
| env_files = | ||
| test.env | ||
| testpaths = | ||
| tests/unit | ||
| tests/integration | ||
| tests/functional |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,90 @@ | ||
| import pytest | ||
| import os | ||
|
|
||
| pytest_plugins = ["dbt.tests.fixtures.project"] | ||
|
|
||
|
|
||
| def pytest_addoption(parser): | ||
| parser.addoption("--profile", action="store", default="apache_spark", type=str) | ||
|
|
||
|
|
||
| # Using @pytest.mark.skip_adapter('apache_spark') uses the 'skip_by_adapter_type' | ||
| # autouse fixture below | ||
| def pytest_configure(config): | ||
| config.addinivalue_line( | ||
| "markers", | ||
| "skip_profile(profile): skip test for the given profile", | ||
| ) | ||
|
|
||
|
|
||
| @pytest.fixture(scope="session") | ||
| def dbt_profile_target(request): | ||
| profile_type = request.config.getoption("--profile") | ||
| if profile_type == "databricks_cluster": | ||
| target = databricks_cluster_target() | ||
| elif profile_type == "databricks_sql_endpoint": | ||
| target = databricks_sql_endpoint_target() | ||
| elif profile_type == "apache_spark": | ||
| target = apache_spark_target() | ||
| elif profile_type == "databricks_http_cluster": | ||
| target = databricks_http_cluster_target() | ||
| else: | ||
| raise ValueError(f"Invalid profile type '{profile_type}'") | ||
| return target | ||
|
|
||
|
|
||
| def apache_spark_target(): | ||
| return { | ||
| "type": "spark", | ||
| "host": "localhost", | ||
| "user": "dbt", | ||
| "method": "thrift", | ||
| "port": 10000, | ||
| "connect_retries": 5, | ||
| "connect_timeout": 60, | ||
| "retry_all": True, | ||
| } | ||
|
|
||
|
|
||
| def databricks_cluster_target(): | ||
| return { | ||
| "type": "spark", | ||
| "method": "odbc", | ||
| "host": os.getenv("DBT_DATABRICKS_HOST_NAME"), | ||
| "cluster": os.getenv("DBT_DATABRICKS_CLUSTER_NAME"), | ||
| "token": os.getenv("DBT_DATABRICKS_TOKEN"), | ||
| "driver": os.getenv("ODBC_DRIVER"), | ||
| "port": 443, | ||
| } | ||
|
|
||
|
|
||
| def databricks_sql_endpoint_target(): | ||
| return { | ||
| "type": "spark", | ||
| "method": "odbc", | ||
| "host": os.getenv("DBT_DATABRICKS_HOST_NAME"), | ||
| "endpoint": os.getenv("DBT_DATABRICKS_ENDPOINT"), | ||
| "token": os.getenv("DBT_DATABRICKS_TOKEN"), | ||
| "driver": os.getenv("ODBC_DRIVER"), | ||
| "port": 443, | ||
| } | ||
|
|
||
|
|
||
| def databricks_http_cluster_target(): | ||
| return { | ||
| "type": "spark", | ||
| "host": os.getenv('DBT_DATABRICKS_HOST_NAME'), | ||
| "cluster": os.getenv('DBT_DATABRICKS_CLUSTER_NAME'), | ||
| "token": os.getenv('DBT_DATABRICKS_TOKEN'), | ||
| "method": "http", | ||
| "port": 443, | ||
| "connect_retries": 5, | ||
| "connect_timeout": 60, | ||
| } | ||
|
|
||
| @pytest.fixture(autouse=True) | ||
| def skip_by_profile_type(request): | ||
| profile_type = request.config.getoption("--profile") | ||
| if request.node.get_closest_marker("skip_profile"): | ||
| if request.node.get_closest_marker("skip_profile").args[0] == profile_type: | ||
| pytest.skip("skipped on '{profile_type}' profile") |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,79 @@ | ||
| import pytest | ||
|
|
||
| from dbt.tests.adapter.basic.test_base import BaseSimpleMaterializations | ||
| from dbt.tests.adapter.basic.test_singular_tests import BaseSingularTests | ||
| from dbt.tests.adapter.basic.test_singular_tests_ephemeral import ( | ||
| BaseSingularTestsEphemeral, | ||
| ) | ||
| from dbt.tests.adapter.basic.test_empty import BaseEmpty | ||
| from dbt.tests.adapter.basic.test_ephemeral import BaseEphemeral | ||
| from dbt.tests.adapter.basic.test_incremental import BaseIncremental | ||
| from dbt.tests.adapter.basic.test_generic_tests import BaseGenericTests | ||
| from dbt.tests.adapter.basic.test_snapshot_check_cols import BaseSnapshotCheckCols | ||
| from dbt.tests.adapter.basic.test_snapshot_timestamp import BaseSnapshotTimestamp | ||
|
|
||
|
|
||
| @pytest.mark.skip_profile('databricks_sql_endpoint') | ||
| class TestSimpleMaterializationsSpark(BaseSimpleMaterializations): | ||
| pass | ||
|
|
||
|
|
||
| class TestSingularTestsSpark(BaseSingularTests): | ||
| pass | ||
|
|
||
|
|
||
| # The local cluster currently tests on spark 2.x, which does not support this | ||
| # if we upgrade it to 3.x, we can enable this test | ||
| @pytest.mark.skip_profile('apache_spark') | ||
| class TestSingularTestsEphemeralSpark(BaseSingularTestsEphemeral): | ||
| pass | ||
|
|
||
|
|
||
| class TestEmptySpark(BaseEmpty): | ||
| pass | ||
|
|
||
|
|
||
| @pytest.mark.skip_profile('databricks_sql_endpoint') | ||
| class TestEphemeralSpark(BaseEphemeral): | ||
| pass | ||
|
|
||
|
|
||
| @pytest.mark.skip_profile('databricks_sql_endpoint') | ||
| class TestIncrementalSpark(BaseIncremental): | ||
| pass | ||
|
|
||
|
|
||
| class TestGenericTestsSpark(BaseGenericTests): | ||
| pass | ||
|
|
||
|
|
||
| # These tests were not enabled in the dbtspec files, so skipping here. | ||
| # Error encountered was: Error running query: java.lang.ClassNotFoundException: delta.DefaultSource | ||
| @pytest.mark.skip_profile('apache_spark') | ||
| class TestSnapshotCheckColsSpark(BaseSnapshotCheckCols): | ||
| @pytest.fixture(scope="class") | ||
| def project_config_update(self): | ||
| return { | ||
| "seeds": { | ||
| "+file_format": "delta", | ||
| }, | ||
| "snapshots": { | ||
| "+file_format": "delta", | ||
| } | ||
| } | ||
|
|
||
|
|
||
| #hese tests were not enabled in the dbtspec files, so skipping here. | ||
| # Error encountered was: Error running query: java.lang.ClassNotFoundException: delta.DefaultSource | ||
| @pytest.mark.skip_profile('apache_spark') | ||
| class TestSnapshotTimestampSpark(BaseSnapshotTimestamp): | ||
| @pytest.fixture(scope="class") | ||
| def project_config_update(self): | ||
| return { | ||
| "seeds": { | ||
| "+file_format": "delta", | ||
| }, | ||
| "snapshots": { | ||
| "+file_format": "delta", | ||
| } | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why does this line fix the tests?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pytest test collection gathers up all classes that start with 'Test', so the test = False marks this class as "not a test".