Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Explain changes to connect_timeout default #3460

Open
1 task done
jiezhen-chen opened this issue Jun 2, 2023 · 0 comments
Open
1 task done

Explain changes to connect_timeout default #3460

jiezhen-chen opened this issue Jun 2, 2023 · 0 comments
Labels
content Improvements or additions to content improvement Use this when an area of the docs needs improvement as it's currently unclear

Comments

@jiezhen-chen
Copy link
Contributor

Contributions

  • I have read the contribution docs, and understand what's expected of me.

Link to the page on docs.getdbt.com requiring updates

https://deploy-preview-3456--docs-getdbt-com.netlify.app/docs/core/connect-data-platform/redshift-setup

What part(s) of the page would you like to see updated?

Previously connect_timeout was defaulted to 10 seconds. This was unintentionally forcing statement timeouts as reported in this issue
the doc needs to be updated that the connect_timeout param is defaulted to None.

Additional information

See PR pertaining this change.
@jiezhen-chen jiezhen-chen added content Improvements or additions to content improvement Use this when an area of the docs needs improvement as it's currently unclear labels Jun 2, 2023
@jiezhen-chen jiezhen-chen mentioned this issue Jun 2, 2023
Merged
2 tasks
mirnawong1 added a commit that referenced this issue Jun 7, 2023
@mirnawong1
update dbt-redshift docs for changes to sslmode, autocommit, connect_…
eb7398d 
…timeout (#3456)

## What are you changing in this pull request and why?

This PR is to update the docs for the following changes in dbt-redshift:

1. **[Mapping sslmode in psycopg2 to ssl & sslmode in
redshift_connector](dbt-labs/dbt-redshift#439

In dbt-redshift 1.5, Python driver switched from psycopg2 to
redshift_connector. redshift_connector has both ssl and sslmode
parameters, while psycopg2 only has sslmode. We've made changes in
dbt-redshift to convert psycopg2' accepted values of sslmode into ssl
and sslmode parameters of redshift_connector. This PR explains the
conversion logic and includes explanation of the sslmode flag.
  #3365

2. **[Adding `autocommit` as a
parameter](dbt-labs/dbt-redshift#475

Autocommit is a new flag that is defaulted to True. This PR adds
explanation of this change and rationale behind this decision in dbt
docs
    #3401

3. **[Connect_timeout default to
None](dbt-labs/dbt-redshift#433
  
Connect_timeout had the default of 10 seconds previously. We changed
this default to None.
    #3460




<!---
Describe your changes and why you're making them. If linked to an open
issue or a pull request on dbt Core, then link to them here! 

To learn more about the writing conventions used in the dbt Labs docs,
see the [Content style
guide](https://github.com/dbt-labs/docs.getdbt.com/blob/current/contributing/content-style-guide.md).
-->

## Checklist
<!--
Uncomment if you're publishing docs for a prerelease version of dbt
(delete if not applicable):
- [ ] Add versioning components, as described in [Versioning
Docs](https://github.com/dbt-labs/docs.getdbt.com/blob/current/contributing/single-sourcing-content.md#versioning-entire-pages)
- [ ] Add a note to the prerelease version [Migration
Guide](https://github.com/dbt-labs/docs.getdbt.com/tree/current/website/docs/guides/migration/versions)
-->
- [x] Review the [Content style
guide](https://github.com/dbt-labs/docs.getdbt.com/blob/current/contributing/content-style-guide.md)
and [About
versioning](https://github.com/dbt-labs/docs.getdbt.com/blob/current/contributing/single-sourcing-content.md#adding-a-new-version)
so my content adheres to these guidelines.
- [ ] Add a checklist item for anything that needs to happen before this
PR is merged, such as "needs technical review" or "change base branch."
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
content Improvements or additions to content improvement Use this when an area of the docs needs improvement as it's currently unclear
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jiezhen-chen