Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update dbt-redshift docs for changes to sslmode, autocommit, connect_timeout #3456

Merged
merged 29 commits into from
Jun 7, 2023
Merged

update dbt-redshift docs for changes to sslmode, autocommit, connect_timeout #3456

merged 29 commits into from
Jun 7, 2023

Conversation

jiezhen-chen
Copy link
Contributor

@jiezhen-chen jiezhen-chen commented Jun 1, 2023 •
edited by dbeatty10
Loading

closes #3360

What are you changing in this pull request and why?

This PR is to update the docs for the following changes in dbt-redshift:

  1. Mapping sslmode in psycopg2 to ssl & sslmode in redshift_connector

    In dbt-redshift 1.5, Python driver switched from psycopg2 to redshift_connector. redshift_connector has both ssl and sslmode parameters, while psycopg2 only has sslmode. We've made changes in dbt-redshift to convert psycopg2' accepted values of sslmode into ssl and sslmode parameters of redshift_connector. This PR explains the conversion logic and includes explanation of the sslmode flag.
    Explain translation of sslmode to sslmode + ssl for redshift_connector #3365

  2. Adding autocommit as a parameter

    Autocommit is a new flag that is defaulted to True. This PR adds explanation of this change and rationale behind this decision in dbt docs
    Add autocommit feature #3401

  3. Connect_timeout default to None

    Connect_timeout had the default of 10 seconds previously. We changed this default to None.
    Explain changes to connect_timeout default #3460

Checklist

  • Review the Content style guide and About versioning so my content adheres to these guidelines.
  • Add a checklist item for anything that needs to happen before this PR is merged, such as "needs technical review" or "change base branch."

@netlify
Copy link

netlify bot commented Jun 1, 2023 •
edited
Loading

✅ Deploy Preview for docs-getdbt-com ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit b4d715d
🔍 Latest deploy log https://app.netlify.com/sites/docs-getdbt-com/deploys/648053d366ca3500078cd978
😎 Deploy Preview https://deploy-preview-3456--docs-getdbt-com.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions github-actions bot added content Improvements or additions to content size: x-small This change will take under 3 hours to fix. labels Jun 1, 2023
@github-actions github-actions bot added size: small This change will take 1 to 2 days to address and removed size: x-small This change will take under 3 hours to fix. labels Jun 1, 2023
@jiezhen-chen jiezhen-chen changed the title update dbt-redshift docs for sslmode change update dbt-redshift docs for changes to sslmode, autocommit, connect_timeout Jun 2, 2023
@github-actions github-actions bot added size: medium This change will take up to a week to address and removed size: small This change will take 1 to 2 days to address labels Jun 2, 2023
@jiezhen-chen jiezhen-chen marked this pull request as ready for review June 2, 2023 19:00
@jiezhen-chen jiezhen-chen requested a review from a team as a code owner June 2, 2023 19:00
jiezhen-chen and others added 2 commits June 6, 2023 09:02
@mirnawong1
Copy link
Contributor

hey @jiezhen-chen , thanks for opening this up! I'll take a look at this for you tomorrow ✨

mirnawong1
mirnawong1 approved these changes Jun 7, 2023
View reviewed changes
Copy link
Contributor

@mirnawong1 mirnawong1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey @jiezhen-chen this looks great and merging this for you now!

@mirnawong1 mirnawong1 enabled auto-merge June 7, 2023 09:48
@mirnawong1 mirnawong1 merged commit eb7398d into dbt-labs:current Jun 7, 2023
@dbeatty10 dbeatty10 mentioned this pull request Jul 13, 2023
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mirnawong1 mirnawong1 mirnawong1 approved these changes

Assignees
No one assigned
Labels
auto update content Improvements or additions to content size: medium This change will take up to a week to address
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Enumerate the sslmode conversion from psychopg2 to redshift_connector
2 participants
@jiezhen-chen @mirnawong1