Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ES6 #1540

Closed
wants to merge 15 commits into from
Closed

ES6 #1540

wants to merge 15 commits into from

Conversation

kum-deepak
Copy link
Collaborator

It will be branch where all ES6 related work will be carried out. Check #1520 for details and progress.

@gordonwoodhull
Copy link
Contributor

Looks like you need to check in package-lock.json in order for Travis to run.

@kum-deepak
Copy link
Collaborator Author

Pushed.

@gordonwoodhull
Copy link
Contributor

gordonwoodhull commented Aug 11, 2019

Looks like Chrome is hanging, but I guess Travis isn't really a priority if the tests are running locally.

Don't think I've seen this particular issue before.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@kum-deepak
Copy link
Collaborator Author

@gordonwoodhull, all the basic setup seem reasonable. It will be good time to create a new branch based on this PR and close this one. This will allow us to target next set of PRs to that branch.

@gordonwoodhull
Copy link
Contributor

Good idea, I created a new branch es6 and merged this there.

Please rebase, since I also bumped the version to 4.0.0-alpha.0 and added an example I had sitting around.

@kum-deepak
Copy link
Collaborator Author

Thanks!

@gordonwoodhull
Copy link
Contributor

Thank you!

@kum-deepak kum-deepak mentioned this pull request Aug 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants