Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duration field type #130

Merged
merged 2 commits into from
Jan 12, 2023
Merged

Conversation

maksym-nazarenko
Copy link
Collaborator

This PR adds new client type MikrotikDuration with int as base type.
It is Marshaled as int (number of seconds) and Unmarshaled from duration string like 2w15m2s into int (number of seconds`
Closes #93

This was referenced Jan 11, 2023
@ddelnano
Copy link
Owner

Looking forward to cleaning up the ugly ttlToSeconds struct tags!

@ddelnano ddelnano merged commit 7306508 into ddelnano:master Jan 12, 2023
@ddelnano ddelnano added the enhancement New feature or request label May 11, 2023
@maksym-nazarenko maksym-nazarenko deleted the duration-field-type branch September 19, 2023 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Scheduler does not support duration notations
2 participants