Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provider/migrate to plugin framework #134

Conversation

maksym-nazarenko
Copy link
Collaborator

This PR is pretty huge, but it holds several crucial things:

  • refactoring of the original provider to be compatible with mux server (mux server is used to combine several providers)
  • rework of main.go to combine providers
  • add .gitattributes file to collapse go.sum in diff viewer by default
  • migrate Scheduler resource to plugin framework to show how it will look like

Relates to #132 (see notes regarding Protocol5 vs Protocolv6)

@maksym-nazarenko maksym-nazarenko marked this pull request as draft January 19, 2023 17:57
@maksym-nazarenko maksym-nazarenko marked this pull request as ready for review January 21, 2023 12:40
@maksym-nazarenko
Copy link
Collaborator Author

hey @ddelnano a lot of changes here, but now it is possible to move resources on-by-one seamlessly to Protocol6 (aka framework)
Some interesting features came with this framework, like validators for lists, interface approach for resource, etc.
Though, some resource implementations were not in the best form, espacially when you have name as Terraform resource (I also implemented my resources in that way, I must admit I have to re-visit those implementations 😬 )

Take a look, when you have time.

@ddelnano
Copy link
Owner

Thanks for investigating how to use this new framework and starting on the scheduler resource! I had a few questions, but overall lgtm.

As for your question here, we could probably drop support for terraform 0.12 to 1.0 soon but since you've done the v6 to v5 translation already let's stick with this. It would be nice if the terraform registry provider metrics had client version to gauge this, but they are pretty bare bones unfortunately.

Screen Shot 2023-02-12 at 10 21 01 PM

@maksym-nazarenko
Copy link
Collaborator Author

@ddelnano I'm okay with supporting older version - just wanted to make this more visible, since on the official page 0.x versions are not even an option for the CLI:
image

@maksym-nazarenko maksym-nazarenko merged commit fd2ec19 into ddelnano:master Feb 23, 2023
@maksym-nazarenko maksym-nazarenko deleted the provider/migrate-to-plugin-framework branch February 23, 2023 19:58
@ddelnano ddelnano added the enhancement New feature or request label May 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants