Add client logic to support read-only Mikrotik properties #143
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
This PR adjusts logic in
client.go
related to Marshaling data before making API calls to a RouterOS device. While pairing with @DawoudMahmud on adding client support for creating Interface Wireguard resources (#140, which is still a WIP), we came across Mikrotik documentation that lists some Wireguard properties to be "Read Only".This led to a test failure (see build here) since a read-only boolean property
running
was included in the interface wireguardadd
command:The issue here is that the unset boolean struct field defaulted to a value of
false
and then was subsequently included in marshaling.What does this PR do?
client.go
in regards to how themikrotik
struct tag is retrieved, doing so in a way that we now check for a newreadonly
tag value.readonly
is specified as a struct tag value, that field will be excluded during marshaling.readonly
struct tag value be present.