Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add github workflow for tfplugindocs linting and unify setup-go and checkout action versions #156

Merged
merged 5 commits into from
May 24, 2023

Conversation

ddelnano
Copy link
Owner

@ddelnano ddelnano commented May 13, 2023

This PR adds a github workflow to prevent missing tfplugindocs updates (follow up for #154). In addition to adding this workflow it upgrades the github action versions of setup-go and checkout for the existing workflows.

Test plan

  • CI job will verify upgrade works for continuous-integration workflow
  • Valid changes have passing tfplugindocs build
  • Invalid build fails as expected
  • Release build is not tested, but CI job had similar upgrade and was successful

@ddelnano ddelnano force-pushed the ddelnano/add-tfplugindocs-linting branch from 17ad522 to b887c48 Compare May 13, 2023 08:04
@ddelnano ddelnano force-pushed the ddelnano/add-tfplugindocs-linting branch from b887c48 to 4b570be Compare May 13, 2023 08:05
@ddelnano ddelnano requested a review from maksym-nazarenko May 13, 2023 08:10
@ddelnano ddelnano added the enhancement New feature or request label May 13, 2023
@ddelnano
Copy link
Owner Author

@maksym-nazarenko this is ready for review when you have a chance.

Copy link
Collaborator

@maksym-nazarenko maksym-nazarenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you for taking care of this
lgtm

@ddelnano ddelnano merged commit bd098a2 into master May 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants