Poc generic crud functions #160
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Very exciting to see how this will make the code generation easier. Change lgtm as is but I'll wait until this is rebased before submitting my approval. |
maksym-nazarenko
force-pushed
the
poc-generic-crud-functions
branch
from
7ebb559 to
0995483
Compare
ddelnano
approved these changes
Jun 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR shows how to use
Generic..Resourcefunctions for Terraform resources (introduced in #161).I created this PR against
terraform-model-client-struct-marshallingbranch to show only resource changes.As you can see, the amount of code significantly reduced, so code generation could be done with less effort from our side - no need to implement
modelToXXXX()andXXXXToModel()anymore