Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature] Add Interface Wireguard Peer resource type #176

Merged
merged 6 commits into from
Aug 11, 2023
Merged

[Feature] Add Interface Wireguard Peer resource type #176

merged 6 commits into from
Aug 11, 2023

Conversation

DawoudMahmud
Copy link
Contributor

Background

This pull request addresses #138

What does this PR do?

  • Add client side code to create Mikrotik Interface Wireguard Peers, which belong to Mikrotik Interface Wireguard instances, with unit testing
  • Add provider side code to register the new resource type of mikrotik_interface_wireguard_peer with supporting acceptance testing
  • Generate new doc file for mikrotik_interface_wireguard_peer resource

How was this tested?

Newly added tests pass and adequately cover all new functionality

@DawoudMahmud DawoudMahmud changed the title Interface wireguard peer [Feature] Add Interface Wireguard Peer resource type Jun 19, 2023
@DawoudMahmud DawoudMahmud mentioned this pull request Jun 19, 2023
Closed
@jdelnano jdelnano requested review from ddelnano and jdelnano June 19, 2023 19:32
@DawoudMahmud DawoudMahmud force-pushed the interface_wireguard_peer branch from 5114da1 to f61ee2a Compare June 19, 2023 20:19
@DawoudMahmud DawoudMahmud force-pushed the interface_wireguard_peer branch from f61ee2a to 530358d Compare June 19, 2023 20:21
@DawoudMahmud @ddelnano
Update mikrotik/resource_interface_wireguard_peer.go
4213855 
Co-authored-by: Dom Del Nano <ddelnano@gmail.com>
@ddelnano ddelnano merged commit 8bc1906 into ddelnano:master Aug 11, 2023
@ddelnano
Copy link
Owner

Thanks for all the wireguard contributions @DawoudMahmud!

@ddelnano ddelnano added the enhancement New feature or request label Aug 11, 2023
@maksym-nazarenko maksym-nazarenko mentioned this pull request Aug 11, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ddelnano ddelnano ddelnano left review comments

@jdelnano jdelnano Awaiting requested review from jdelnano

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DawoudMahmud @ddelnano