Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: do not set default value for netmask in mikrotik_dhcp_server_network #220

Conversation

maksym-nazarenko
Copy link
Collaborator

This PR removes default value for netmask in mikrotik_dhcp_server_network.
The root cause of the issue is that netmask has integer type in RouterOS but in the provider it is string, hence empty value in RouterOS (0 zero) is not the same as empty value in provider ("" empty string).

Resolves #219

@ddelnano ddelnano merged commit 41ae258 into ddelnano:master Jan 21, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Provider crash in mikrotik_dhcp_server_network resource
2 participants