Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use mnazarenko/docker-routeros #235

Merged
merged 5 commits into from
Nov 30, 2024

Conversation

maksym-nazarenko
Copy link
Collaborator

@maksym-nazarenko maksym-nazarenko commented Jul 9, 2024

Fixes #224

This PR introduces new source for RouterOS image - mnazarenko/docker-routeros

Update
@ddelnano RouterOS 7.14.3 and 7.15 behave differently.

7.15

[admin@MikroTik] /ip/dhcp-server> add name=test interface=ether1
[admin@MikroTik] /ip/dhcp-server> :put [get [find]]
.id=*1;address-pool=static-only;disabled=false;dynamic=false;interface=ether1;invalid=false;lease-script=;lease-time=00:30:00;name=test;use-radius=no
[admin@MikroTik] /ip/dhcp-server> set test authoritative=no
[admin@MikroTik] /ip/dhcp-server> :put [get [find]]
.id=*1;address-pool=static-only;authoritative=no;disabled=false;dynamic=false;interface=ether1;invalid=false;lease-script=;lease-time=00:30:00;name=test;use-radius=no
[admin@MikroTik] /ip/dhcp-server> set test authoritative=yes
[admin@MikroTik] /ip/dhcp-server> :put [get [find]]
.id=*1;address-pool=static-only;disabled=false;dynamic=false;interface=ether1;invalid=false;lease-script=;lease-time=00:30:00;name=test;use-radius=no

7.14

[admin@MikroTik] /ip/dhcp-server> add name=test interface=ether1
[admin@MikroTik] /ip/dhcp-server> :put [get [find]]
.id=*1;address-pool=static-only;authoritative=yes;disabled=false;dynamic=false;interface=ether1;invalid=false;lease-script=;lease-time=00:30:00;name=test;use-radius=no
[admin@MikroTik] /ip/dhcp-server> set test authoritative=no
[admin@MikroTik] /ip/dhcp-server> :put [get [find]]
.id=*1;address-pool=static-only;disabled=false;dynamic=false;interface=ether1;invalid=false;lease-script=;lease-time=00:30:00;name=test;use-radius=no
[admin@MikroTik] /ip/dhcp-server> set test authoritative=yes
[admin@MikroTik] /ip/dhcp-server> :put [get [find]]
.id=*1;address-pool=static-only;authoritative=yes;disabled=false;dynamic=false;interface=ether1;invalid=false;lease-script=;lease-time=00:30:00;name=test;use-radius=no

Note that 7.14 hides non-default authoritative value, where 7.15 hides default value

I noticed something similar last year (one of the resources got new field which is not available in older version).
I think, it's worth to invest some time and think how to handle this in the future: support at runtime or just support pre-defined set of RouterOS versions, like [6.49.3, 7.15.2, ....] which will be part of our CI testing.

@maksym-nazarenko maksym-nazarenko added the bug Something isn't working label Jul 9, 2024
@maksym-nazarenko maksym-nazarenko requested a review from ddelnano July 9, 2024 20:43
@ddelnano
Copy link
Owner

@maksym-nazarenko good from my end. Feel free to fix the 7.15 issues later or in this PR.

@maksym-nazarenko maksym-nazarenko merged commit e01affd into ddelnano:master Nov 30, 2024
4 checks passed
@maksym-nazarenko maksym-nazarenko deleted the fix-tests-workflow branch November 30, 2024 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RouterOS container fails to start in actions
2 participants