Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct Mikrotik command building #36

Merged
merged 7 commits into from
May 18, 2021

Conversation

jdelnano
Copy link
Collaborator

@jdelnano jdelnano commented May 5, 2021

Correct and leverage the Marshal client function to more cleanly and effectively construct Mikrotik commands. Addresses issue #30. It's a big one 🙂 @ddelnano

@jdelnano jdelnano requested a review from ddelnano May 5, 2021 01:31
@jdelnano
Copy link
Collaborator Author

jdelnano commented May 7, 2021

@ddelnano do you mind that I address, in a subsequent PR, the Mikrotik queries where resources are "found"? This will require updates to client and provider code, and this PR is pretty large as is.

Copy link
Owner

@ddelnano ddelnano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not all the way through this yet but we can follow up with the other command building for queries and print commands in a later change.

client/bgp_instance.go Show resolved Hide resolved
client/scheduler_test.go Outdated Show resolved Hide resolved
mikrotik/resource_dhcp_lease.go Outdated Show resolved Hide resolved
@jdelnano jdelnano force-pushed the jdelnano/correct-command-building branch from 9212a5e to 5ebac2c Compare May 10, 2021 01:37
@jdelnano jdelnano requested a review from ddelnano May 10, 2021 01:38
mikrotik/resource_dhcp_lease.go Show resolved Hide resolved
mikrotik/resource_dns_record.go Show resolved Hide resolved
mikrotik/resource_pool.go Outdated Show resolved Hide resolved
mikrotik/resource_pool.go Outdated Show resolved Hide resolved
mikrotik/resource_scheduler.go Outdated Show resolved Hide resolved
mikrotik/resource_dns_record.go Show resolved Hide resolved
mikrotik/resource_dhcp_lease.go Outdated Show resolved Hide resolved
@jdelnano jdelnano requested a review from ddelnano May 11, 2021 15:33
@jdelnano
Copy link
Collaborator Author

@ddelnano I've created the following two issues:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants