-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Correct Mikrotik command building #36
Conversation
@ddelnano do you mind that I address, in a subsequent PR, the Mikrotik queries where resources are "found"? This will require updates to client and provider code, and this PR is pretty large as is. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not all the way through this yet but we can follow up with the other command building for queries and print commands in a later change.
9212a5e
to
5ebac2c
Compare
@ddelnano I've created the following two issues:
|
Correct and leverage the
Marshal
client function to more cleanly and effectively construct Mikrotik commands. Addresses issue #30. It's a big one 🙂 @ddelnano