Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix fix in filename #53

Merged
merged 1 commit into from
Mar 24, 2024
Merged

Fix fix in filename #53

merged 1 commit into from
Mar 24, 2024

Conversation

ChillerDragon
Copy link
Collaborator

@ChillerDragon ChillerDragon commented Nov 13, 2023

@@ -9,7 +9,7 @@
   id="svg5"
   inkscape:version="1.3 (0e150ed6c4, 2023-07-21)"
   xml:space="preserve"
-  sodipodi:docname="generic_unhookable_0.7_fix.svg"
+  sodipodi:docname="generic_unhookable_0.7.svg"
   inkscape:export-xdpi="96"
   inkscape:export-ydpi="96"
   xmlns:inkscape="http://www.inkscape.org/namespaces/inkscape"

@ChillerDragon
Copy link
Collaborator Author

Should we add that to the CI @Jupeyy ?

@Jupeyy
Copy link
Member

Jupeyy commented Nov 13, 2023

why does that attribute even exist in first place xd

dunno if it's important enough, what could go wrong in worst case? xd

@ChillerDragon
Copy link
Collaborator Author

why does that attribute even exist in first place xd

dunno if it's important enough, what could go wrong in worst case? xd

Nothing ever breaks it just gets overwritten. It's just spy tracking inserted by svg editors. Imo it's weird if it's wrong.

@Jupeyy
Copy link
Member

Jupeyy commented Nov 13, 2023

ok let's say it like that:
if you are motivated to add it to the CI, i'd happily merge it ^^

@Jupeyy Jupeyy merged commit 5b3154d into ddnet:main Mar 24, 2024
3 checks passed
@Jupeyy Jupeyy mentioned this pull request Mar 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants