Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add desert_main #56

Merged
merged 1 commit into from
Mar 24, 2024
Merged

Add desert_main #56

merged 1 commit into from
Mar 24, 2024

Conversation

johannesHHM
Copy link
Contributor

compare

test

The hardest part was trying to get the shadow on all of the "main" tiles to match up, and look like the original. The originals shadows do not tile great when zoomed in, I think mine are a bit better, but still not perfect (this mostly an export bug, they line up fine in the svg)

shadow

Pixel diff of remake and original, the shadowy-areas have few perfect pixels.

compare mapres/desert_main.png /usr/share/ddnet/data/mapres/desert_main.png -compose src diff.png

diff

A couple of bugs that I fixed / didn't replicate:

  • tile 23 has some transparency inside of it
  • tile 98's bottom line is a slightly different shade of brown then the other tiles it should tile with
  • tile 136's wire shadow does not line up with the other wire tiles
  • tile 22 has some light sand pixels coming out where it shouldn't (probably export bug)
  • all the wall background inner corner tiles light shade line don't line up with the other tiles it tiles with

closes #55

@Jupeyy Jupeyy merged commit d5a7190 into ddnet:main Mar 24, 2024
3 checks passed
@Jupeyy
Copy link
Member

Jupeyy commented Mar 24, 2024

@ChillerDragon file name here is wrong too like in #53 if u still motivated for the CI xd

@johannesHHM looks good, thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

WIP: desert_main.svg
2 participants