-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow installation of debug version of Python #18
Conversation
They totally do! They're basically the same packages but without docs, libpython symbols, and the news file: https://github.com/deadsnakes/nightly#limitations
Hmmm, this is a good point -- for now it's probably fine to keep them the same -- if someone has a usecase for doing both at the same time then this can be enhanced later |
Oh, do you then prefer to have a separate option, to support all 4 combinations (released vs. nightly, debug vs. release), rather than the 3 versions now (release, debug, nightly)? E.g. something like this:
|
Yeah that probably makes sense |
Let's see if this works :-) I've pushed an update to pybind/pybind11#2746 |
Seems so; if I didn't mess up the original use, with |
121a0c9
to
fb997be
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great! Thanks for the smooth merge & release! |
and thank you for the patch! <3 |
It would be useful if the GitHub Action could also easily install and setup a debug version of Python. This PR recognizes a
-dbg
suffix, and also install the debug version and uses it to setup the virtual environment.Since there are no tests, I am already using my branch in the CI runs here, and it seems to work: pybind/pybind11#2746
Things to consider:
-dbg-dev
or-dev-dbg
isn't recognized/allowed, but the nightly builds don't seem to have a debug version?dbg: true
ordebug: true
; this might make more sense if the nightly builds would have a debug build, but if they don't, it might be unexpected that such a combination would not work?~/venv-{version}
. Should this be~/venv-{version}-dbg
, such that two installations of the same version could coexist as debug and non-debug build? But then-dev
doesn't currently allow this either, it seems.