Fix the issue that input values seems to be strings rather than e.g. booleans #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asottile
reviewed
Jan 13, 2021
asottile
force-pushed
the
fix-input-boolean
branch
from
b0b2336 to
2aa828b
Compare
|
Thanks, once again! |
hugovk
pushed a commit
to hugovk/action
that referenced
this pull request
Feb 8, 2024
Update example to newer actions/* versions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Seems I made a mistake in #18. The values of an action's input are always strings, so even when passing
false(the boolean), that's going to be'false'(the string) and thus interpreted astrue(the boolean).Found in pybind/pybind11#2792, demonstrating the fix. Compare the following two commits:
deadsnakes/action@2.1.0: https://github.com/pybind/pybind11/runs/1698416221#step:3:76 (includepython3.10-dbg)YannickJadoul/deadsnakes-action@fix-input-boolean: https://github.com/pybind/pybind11/runs/1698540649#step:3:76 (doesn't includepython3.10-dbganymore)Sorry for not catching this in #18! The default values for the inputs
action.ymlare apparently booleans...