VW: get VIN from camera without comma power (commaai#31851)

* add VW camera to VIN addrs * correct VW query * consistent * update refs
deanlee · Apr 8, 2024 · 22aa9a4 · 22aa9a4
1 parent d114924
commit 22aa9a4
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/selfdrive/car/tests/test_fw_fingerprint.py b/selfdrive/car/tests/test_fw_fingerprint.py
@@ -236,7 +236,7 @@ def _assert_timing(self, avg_time, ref_time):
 
  def test_startup_timing(self):
  # Tests worse-case VIN query time and typical present ECU query time
- vin_ref_times = {'worst': 1.2, 'best': 0.6} # best assumes we go through all queries to get a match
+ vin_ref_times = {'worst': 1.4, 'best': 0.7} # best assumes we go through all queries to get a match
  present_ecu_ref_time = 0.75
 
  def fake_get_ecu_addrs(*_, timeout):

diff --git a/selfdrive/car/vin.py b/selfdrive/car/vin.py
@@ -23,6 +23,7 @@ def get_vin(logcan, sendcan, buses, timeout=0.1, retry=2, debug=False):
  (StdQueries.OBD_VIN_REQUEST, StdQueries.OBD_VIN_RESPONSE, (0, 1), STANDARD_VIN_ADDRS, FUNCTIONAL_ADDRS, 0x8),
  (StdQueries.GM_VIN_REQUEST, StdQueries.GM_VIN_RESPONSE, (0,), [0x24b], None, 0x400), # Bolt fwdCamera
  (StdQueries.KWP_VIN_REQUEST, StdQueries.KWP_VIN_RESPONSE, (0,), [0x797], None, 0x3), # Nissan Leaf VCM
+ (StdQueries.UDS_VIN_REQUEST, StdQueries.UDS_VIN_RESPONSE, (0,), [0x74f], None, 0x6a), # Volkswagen fwdCamera
  ):
  if bus not in valid_buses:
  continue