Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wip: move to JupyterLab 4.x #53

Merged
merged 1 commit into from
Oct 26, 2023
Merged

wip: move to JupyterLab 4.x #53

merged 1 commit into from
Oct 26, 2023

Conversation

agoose77
Copy link
Contributor

@agoose77 agoose77 commented Sep 30, 2023

This PR makes it possible to build jupyterlab-deck for JupyterLab 4. I didn't mess around with supporting 3.x and 4.x at the same time. Please consider this PR a "first stab" to try and reduce the busy work of @bollwyvl et al.

I expect someone with a better knowledge of doit should improve my changes to dodo.py.

Comment on lines +40 to +41
#- ipydrawio
#- jupyter-videochat
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These still pull in 3.x

@bollwyvl
Copy link
Contributor

bollwyvl commented Oct 1, 2023

Great ❤️

I'll do some local plumbing and see where it leads... might have to push to a new branch, as I think main by default is protected these days. Can either sub-pr, or whatever seems to work.

@bollwyvl bollwyvl mentioned this pull request Oct 2, 2023
7 tasks
@bollwyvl bollwyvl merged commit 3ef666e into deathbeds:main Oct 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants