Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support JupyterLab 4 and Notebook 7 #54

Merged
merged 33 commits into from
Oct 26, 2023
Merged

Conversation

bollwyvl
Copy link
Contributor

@bollwyvl bollwyvl commented Oct 2, 2023

References

Code Changes

  • handle rest of API changes vs Lab 4 (mostly .model.getMetadata, etc)
  • add basic handlers for notebook shell differences
  • update tests
  • adopt ruff
  • bump jupyterlite stack
  • update typescript, prettier, etc
  • handle yarn 3 "features"

@codecov
Copy link

codecov bot commented Oct 2, 2023

Codecov Report

Merging #54 (3496ee9) into main (dc0abf2) will decrease coverage by 0.19%.
The diff coverage is 83.65%.

@@            Coverage Diff             @@
##             main      #54      +/-   ##
==========================================
- Coverage   92.82%   92.64%   -0.19%     
==========================================
  Files          14       15       +1     
  Lines        1268     1291      +23     
  Branches      248      266      +18     
==========================================
+ Hits         1177     1196      +19     
- Misses         45       49       +4     
  Partials       46       46              
Flag Coverage Δ
front-end 92.58% <83.65%> (-0.14%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
js/jupyterlab-deck/src/markdown/presenter.ts 93.24% <ø> (ø)
js/jupyterlab-deck/src/notebook/extension.ts 100.00% <ø> (ø)
js/jupyterlab-deck/src/plugin.ts 100.00% <100.00%> (ø)
js/jupyterlab-deck/src/tokens.ts 100.00% <ø> (ø)
js/jupyterlab-deck/src/tools/design.tsx 97.56% <100.00%> (ø)
js/jupyterlab-deck/src/tools/layover.ts 95.34% <100.00%> (ø)
src/jupyterlab_deck/__init__.py 100.00% <ø> (ø)
src/jupyterlab_deck/_version.py 100.00% <ø> (ø)
src/jupyterlab_deck/tests/test_metadata.py 100.00% <ø> (ø)
js/jupyterlab-deck/src/manager.ts 91.17% <97.67%> (+2.98%) ⬆️
... and 4 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@agoose77
Copy link
Contributor

@bollwyvl I'm happy to close my PR in favour of this. Are there any outstanding tasks I can contribute in this PR? :)

@bollwyvl bollwyvl marked this pull request as ready for review October 26, 2023 00:47
@bollwyvl bollwyvl changed the title Support JupyterLab4 and Notebook 7 Support JupyterLab 4 and Notebook 7 Oct 26, 2023
This was referenced Oct 26, 2023
@bollwyvl bollwyvl merged commit ac37c3c into deathbeds:main Oct 26, 2023
@bollwyvl bollwyvl added this to the 0.2.0 milestone Oct 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants