Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support JupyterLab 4 and Notebook 7 #54

Merged
merged 33 commits into from
Oct 26, 2023
Merged
Changes from 1 commit
Commits
Show all changes
33 commits
Select commit Hold shift + click to select a range
3ef666e
wip: move to JupyterLab 4.x
agoose77 Sep 30, 2023
da2891c
forward, environments
bollwyvl Sep 30, 2023
5c282ed
remove use-only-tar-bz2
bollwyvl Oct 2, 2023
4bfd2fc
linting, fix rtd
bollwyvl Oct 2, 2023
190693f
immutable yarn in CI, ext deps
bollwyvl Oct 2, 2023
8992dfc
try more config normalization
bollwyvl Oct 2, 2023
5b36dfb
update roaming location
bollwyvl Oct 2, 2023
9c4f7dc
bump lite
bollwyvl Oct 9, 2023
ee5d091
more work on setting, validating config overrides
bollwyvl Oct 9, 2023
4aad7bd
bump fonts
bollwyvl Oct 23, 2023
db8e3e3
linting
bollwyvl Oct 23, 2023
6027c73
use labcompat from fonts
bollwyvl Oct 23, 2023
8eb2afb
start lab 3.5 env
bollwyvl Oct 23, 2023
ae53683
start 3/4 compat
bollwyvl Oct 24, 2023
9b80251
more labcompat
bollwyvl Oct 24, 2023
b1d6677
atest lab compat
bollwyvl Oct 24, 2023
e3bafa9
bump lite core
bollwyvl Oct 24, 2023
f857cda
selected compat
bollwyvl Oct 24, 2023
6bb65ac
tidy up screenshots
bollwyvl Oct 24, 2023
ae47048
clean up legacy setup
bollwyvl Oct 24, 2023
432ee70
more atest reporting
bollwyvl Oct 24, 2023
a31dc29
update report locations
bollwyvl Oct 24, 2023
66ac6c1
move legacy tasks together
bollwyvl Oct 24, 2023
f3804fc
roll back version
bollwyvl Oct 24, 2023
4aa2dd9
update ci
bollwyvl Oct 24, 2023
ccacb5f
fix version
bollwyvl Oct 24, 2023
bd13ba2
fix badges
bollwyvl Oct 24, 2023
64905ad
add extra shell._main.update for notebook after stopping deck
bollwyvl Oct 24, 2023
c90e389
move legacy
bollwyvl Oct 24, 2023
2cea56a
bump fonts
bollwyvl Oct 24, 2023
dd6ce92
handle some iterators
bollwyvl Oct 24, 2023
11ff44e
more labcompat
bollwyvl Oct 24, 2023
3496ee9
spelling
bollwyvl Oct 25, 2023
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
atest lab compat
bollwyvl committed Oct 24, 2023

Verified

This commit was signed with the committer’s verified signature.
vjik Sergei Predvoditelev
commit b1d66778a6e2c86759e4d9ddc4763bc9608ad5a9
10 changes: 10 additions & 0 deletions atest/resources/CodeMirror.resource
Original file line number Diff line number Diff line change
@@ -4,18 +4,28 @@ Documentation Keywords for working with CodeMirror
Library JupyterLibrary


*** Variables ***
${CM JS TO STRING} view.state.doc.toString()


*** Keywords ***
Initialize CodeMirror
[Documentation] Fix apparently-broken CSS/JS variable updates.
Update Globals For JupyterLab Version
Set Suite Variable ${CM CSS EDITOR} ${CM CSS EDITOR} children=${TRUE}
Set Suite Variable ${CM JS INSTANCE} ${CM JS INSTANCE} children=${TRUE}
IF "${CM JS INSTANCE}" == "${CM6 JS INSTANCE}"
Set Suite Variable ${CM JS TO STRING} view.state.doc.toString() children=${TRUE}
ELSE
Set Suite Variable ${CM JS TO STRING} getValue() children=${TRUE}
END

Return CodeMirror Method
[Documentation] Construct and a method call against in the CodeMirror attached to the element
... that matches a ``css`` selector with the given ``js`` code.
... The CodeMirror editor instance will be available as `cm`.
[Arguments] ${css} ${js}

${result} = Execute JavaScript
... return (() => {
... const cm = document.querySelector(`${css}`)${CM JS INSTANCE};
2 changes: 1 addition & 1 deletion atest/resources/Lab.resource
Original file line number Diff line number Diff line change
@@ -111,7 +111,7 @@ Wait Until Cell Metadata Contains

${ok} = Set Variable ${FALSE}
FOR ${i} IN RANGE ${attempts}
${src} = Return CodeMirror Method ${CSS_LAB_CELL_META_JSON} ${CM CSS EDITOR} view.state.doc.toString()
${src} = Return CodeMirror Method ${CSS_LAB_CELL_META_JSON} ${CM CSS EDITOR} ${CM JS TO STRING}
${contains} = Set Variable ${src.__contains__('''${text}''')}
IF ${inverse} and not ${contains}
${ok} = Set Variable ${TRUE}