-
-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Datetime widget fixes and improvements #7261
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Pass avatar_url un git-gateway backend * Fix lint * Fix ts issue
* fix: update ukrainian lang * fix: run format * fix: update node-polyglot
Reverts the change to `getPullRequestAuthor` in the GitHub backend from 4f419dd, so that it fetches the PR author's name as before. In the AWS Cognito GitHub backend, return the GitHub login as the PR author. Co-authored-by: Martin Jagodic <jagodicmartin1@gmail.com>
…Bearer" (#7242) The authorization type "Bearer" is more widely recognized than "token". E.g. Gitlab requires that you use "Bearer". This should fix #7172 where apparently login with Github was broken by this line: #7172 (comment) See also: #5844 (comment)
In case of a self-hosted Gitlab, the API request to get the default branch always call gitlab.com. This commit allow to pass a custom API root from the config to the API call. Fix #7168 Co-authored-by: Martin Jagodic <jagodicmartin1@gmail.com>
…#7227) * fix(i18n): allow to store the new entry in the draft after a pre save * feat(persistEntry): test preSave that return data or entry map * fix(linter): expected property shorthand object-shorthand * fix: format backend spec, update caniuse-lite --------- Co-authored-by: Martin Jagodic <jagodicmartin1@gmail.com>
* fix(i18n): improve Thai locale * chore(lint): lint Thai locale --------- Co-authored-by: Martin Jagodic <jagodicmartin1@gmail.com>
Looks like you also fixed this one: #7212 |
demshy
approved these changes
Aug 12, 2024
This was referenced Aug 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Targeting all open issues with the label area: extensions/widgets/datetime. Hopefully, I get it right this time.
default: '{{now}}'
option to enable the current behavior of displaying the current time (using the specified format)picker_utc: true
Z
in format andpicker_utc: true
work togetherformat
is set,date_format
andtime_format
(if strings) are ignored (Format ignored for datetime widget when date and time format specified #7250)