Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

score_trajectory() can return score worse than error_score #131

Closed
sdahdah opened this issue Jan 18, 2023 · 0 comments · Fixed by #132
Closed

score_trajectory() can return score worse than error_score #131

sdahdah opened this issue Jan 18, 2023 · 0 comments · Fixed by #132
Assignees
@sdahdah
Labels
bug Something isn't working
Milestone
v1.2.0

Comments

@sdahdah
Copy link
Member

sdahdah commented Jan 18, 2023

Expected Behavior

error_score should be the worst possible score returned by score_trajectory.

Actual Behavior

If error_score=-1, for example, a diverging trajectory could return a better score than a really bad bounded trajectory. This is problematic when pykoop is paired with a hyperparameter optimizer like skopt.BayesSearchCV.
@sdahdah sdahdah added the bug Something isn't working label Jan 18, 2023
@sdahdah sdahdah added this to the v1.1.4 milestone Jan 18, 2023
@sdahdah sdahdah self-assigned this Jan 18, 2023
@sdahdah sdahdah mentioned this issue Jan 18, 2023
Merged
5 tasks
@sdahdah sdahdah linked a pull request Jan 18, 2023 that will close this issue
score_trajectory can return score worse than error score #132
Merged
5 tasks
@sdahdah sdahdah modified the milestones: v1.1.4, v1.2.0 Aug 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sdahdah sdahdah

Labels
bug Something isn't working
Projects
None yet
Milestone
v1.2.0
Development

Successfully merging a pull request may close this issue.

score_trajectory can return score worse than error score decargroup/pykoop
1 participant
@sdahdah