Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix performance issues in predict_trajectory() #150

Closed
sdahdah opened this issue Aug 21, 2023 · 0 comments · Fixed by #151
Closed

Fix performance issues in predict_trajectory() #150

sdahdah opened this issue Aug 21, 2023 · 0 comments · Fixed by #151
Assignees
@sdahdah
Labels
bug Something isn't working
Milestone
v1.2.0

Comments

@sdahdah
Copy link
Member

sdahdah commented Aug 21, 2023 •
edited
Loading

According to cProfile, check_array and pandas.unique take over 60% of the runtime. Need to avoid checking the input every iteration of the prediction.

May need to convert episode feature to integers (and update documentation).
@sdahdah sdahdah added the bug Something isn't working label Aug 21, 2023
@sdahdah sdahdah added this to the v1.2.0 milestone Aug 21, 2023
@sdahdah sdahdah self-assigned this Aug 21, 2023
@sdahdah sdahdah linked a pull request Aug 30, 2023 that will close this issue
Fix performance issues in pykoop.predict_trajectory() #151
Merged
5 tasks
@sdahdah sdahdah mentioned this issue Aug 30, 2023
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sdahdah sdahdah

Labels
bug Something isn't working
Projects
None yet
Milestone
v1.2.0
Development

Successfully merging a pull request may close this issue.

Fix performance issues in pykoop.predict_trajectory() decargroup/pykoop
1 participant
@sdahdah