Remove the safeSingletonContract property from FractalContracts and BaseContracts interfaces #1660
Conversation
✅ Deploy Preview for fractal-dev ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
adamgall
force-pushed
the
remove-zodiacModuleProxyFactoryContract-from-useSafeContracts
branch
from
75f435e
to
5ebaf5b
Compare
adamgall
force-pushed
the
remove-safeSingletonContract-from-FractalContracts-and-BaseContracts
branch
from
107633c
to
476155d
Compare
| if (!isHex(encodedAddOwnerWithThreshold)) { | ||
| return; | ||
| } |
There was a problem hiding this comment.
the isHex function seems to be off and on used in conjunction with the encodeFunctionData. is there a reason its being used in some places and not others?
There was a problem hiding this comment.
viem's encodeFunctionData() will always return a "Hex" string, so no need to use the isHex function on data returned from that function.
It was needed when using ethers interface.encodeFunctionData(), because that function just returns a plain string, and typescript doesn't allow plain strings to be passed into viem functions that are expecting Hex.
As we progress through this refactor, we'll be removing all of these isHex checks, because we won't be using ethers any longer!
It's jsut needed temporarily for now as we have both ethers and viem in the codebase.
| bytecodeHash: keccak256( | ||
| encodePacked( | ||
| ['bytes', 'uint256'], | ||
| [ | ||
| safeFactoryContractProxyCreationCode, | ||
| hexToBigInt(getAddress(safeSingletonContract.address)), | ||
| ], |
There was a problem hiding this comment.
Why the removal of the getAddress function here?
There was a problem hiding this comment.
Presumably because the safeSingletonContract type went from an ethers contract object to a viem contract object.
ethers contract.address is a string
viem contract.address is an Address
adamgall
force-pushed
the
remove-zodiacModuleProxyFactoryContract-from-useSafeContracts
branch
from
5ebaf5b
to
917cc5b
Compare
adamgall
force-pushed
the
remove-safeSingletonContract-from-FractalContracts-and-BaseContracts
branch
from
476155d
to
b81091e
Compare
adamgall
force-pushed
the
remove-zodiacModuleProxyFactoryContract-from-useSafeContracts
branch
2 times, most recently
from
ccd09f8
to
3b3a125
Compare
…aseContracts interfaces
adamgall
force-pushed
the
remove-safeSingletonContract-from-FractalContracts-and-BaseContracts
branch
from
b81091e
to
77d3fbe
Compare
adamgall
deleted the
remove-safeSingletonContract-from-FractalContracts-and-BaseContracts
branch
Please review and merge #1658 first.