Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the safeSingletonContract object from useSafeContracts #1661

Conversation

adamgall
Copy link
Member

@adamgall adamgall commented May 6, 2024

Please review and merge #1660 first.

@adamgall adamgall self-assigned this May 6, 2024
Copy link

netlify bot commented May 6, 2024

Deploy Preview for fractal-dev ready!

Name Link
🔨 Latest commit 7c953d3
🔍 Latest deploy log https://app.netlify.com/sites/fractal-dev/deploys/663bd7ac86639a0008e8f816
😎 Deploy Preview https://deploy-preview-1661.app.dev.fractalframework.xyz
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@adamgall adamgall force-pushed the remove-safeSingletonContract-from-FractalContracts-and-BaseContracts branch from 107633c to 476155d Compare May 7, 2024 17:58
@adamgall adamgall force-pushed the remove-safeSingletonContract-from-useSafeContracts branch from 2670d6e to 91c0f27 Compare May 7, 2024 17:58
Copy link
Contributor

@Da-Colon Da-Colon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, Lint error/warning is carried through to this PR as well.

@adamgall adamgall force-pushed the remove-safeSingletonContract-from-FractalContracts-and-BaseContracts branch from 476155d to b81091e Compare May 7, 2024 23:28
@adamgall adamgall force-pushed the remove-safeSingletonContract-from-useSafeContracts branch from 91c0f27 to f4a19d9 Compare May 7, 2024 23:28
@adamgall adamgall force-pushed the remove-safeSingletonContract-from-FractalContracts-and-BaseContracts branch from b81091e to 77d3fbe Compare May 8, 2024 19:47
Base automatically changed from remove-safeSingletonContract-from-FractalContracts-and-BaseContracts to root/remove-typechain May 8, 2024 19:50
@adamgall adamgall force-pushed the remove-safeSingletonContract-from-useSafeContracts branch from f4a19d9 to 7c953d3 Compare May 8, 2024 19:51
@adamgall adamgall marked this pull request as ready for review May 8, 2024 19:51
@adamgall adamgall merged commit c8acbc7 into root/remove-typechain May 8, 2024
7 checks passed
@adamgall adamgall deleted the remove-safeSingletonContract-from-useSafeContracts branch May 8, 2024 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants