feat(Names): Stop Burning MANA when registering a Name #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* fix: Npm install issues by refactoring the repo * fix: Test script * feat: Support coverage * feat: Remove unused config * fix: CI * fix: CI * chore: EOL * chore: Update CI
* fix: Tests performance --------- Co-authored-by: Nando <24811313+fzavalia@users.noreply.github.com>
…es (#40) * feat: Clone DCLController into DCLControllerV2 o contain future changes * chore: EOL * chore: EOL
* feat: Receive fee collector in constructor * fix: FakeControllerV2 * chore: Test fee collector provided in constructor * chore: Update test
* feat: Receive fee collector in constructor * fix: FakeControllerV2 * chore: Test fee collector provided in constructor * feat: Function to set the fee collector * chore: Test that constructor is using the internal set fee collector function * chore: Test setFeeCollector function
* feat: Receive fee collector in constructor * fix: FakeControllerV2 * chore: Test fee collector provided in constructor * feat: Function to set the fee collector * chore: Test that constructor is using the internal set fee collector function * chore: Test setFeeCollector function * feat: Transfer tokens to fee collector instead of burning * chore: Fix tests * chore: Test that the fee is transferred to the fee collector * Update contracts/ens/DCLControllerV2.sol Co-authored-by: Ignacio Mazzara <nachomazzara@gmail.com> Signed-off-by: Fernando Zavalia <24811313+fzavalia@users.noreply.github.com> * chore: Update test * chore: Update test * chore: Update test --------- Signed-off-by: Fernando Zavalia <24811313+fzavalia@users.noreply.github.com> Co-authored-by: Ignacio Mazzara <nachomazzara@gmail.com>
* feat: Validate fee collector is not address 0 * chore: Test that the fee collector is not 0
* feat: Add script to deploy new controller * chore: EOL * chore: Add default network * chore: Add default rpc url for deploy * chore: Remove default network * chore: Rename fixture
* feat: Provide owner on constructor * chore: Test transfer ownership * chore: Add natspec
* feat: Remove requireBalance function * chore: Fix tests
* chore: Add comment about token * chore: Remove * chore: Add comment in contructor * chore: Update comment * chore: Update comment * chore: Remove dot
fzavalia
changed the title
* chore: Update README * chore: Update deploy script
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Send the fee to a fee collector instead
Feature branch for all issues related to #24