-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Provide owner on constructor #51
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@@ -33,7 +33,7 @@ contract DCLControllerV2 is Ownable { | |||
* @param _registrar - address of the DCL registrar contract | |||
* @param _feeCollector - address of the fee collector | |||
*/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we add the dev notation for the new param?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Completely forgot, nice catch
nachomazzara
approved these changes
Mar 27, 2023
fzavalia
added a commit
that referenced
this pull request
Apr 18, 2023
* fix: Fix npm install issues by refactoring the repo (#34) * fix: Npm install issues by refactoring the repo * fix: Test script * feat: Support coverage * feat: Remove unused config * fix: CI * fix: CI * chore: EOL * chore: Update CI * fix: Tests performance (#39) * fix: Tests performance --------- Co-authored-by: Nando <24811313+fzavalia@users.noreply.github.com> * feat: Clone DCLController into DCLControllerV2 o contain future changes (#40) * feat: Clone DCLController into DCLControllerV2 o contain future changes * chore: EOL * chore: EOL * feat: Provide fee collector in constructor (#41) * feat: Receive fee collector in constructor * fix: FakeControllerV2 * chore: Test fee collector provided in constructor * chore: Update test * feat: Add function to update the fee collector (#42) * feat: Receive fee collector in constructor * fix: FakeControllerV2 * chore: Test fee collector provided in constructor * feat: Function to set the fee collector * chore: Test that constructor is using the internal set fee collector function * chore: Test setFeeCollector function * feat: Send fee to fee collector (#43) * feat: Receive fee collector in constructor * fix: FakeControllerV2 * chore: Test fee collector provided in constructor * feat: Function to set the fee collector * chore: Test that constructor is using the internal set fee collector function * chore: Test setFeeCollector function * feat: Transfer tokens to fee collector instead of burning * chore: Fix tests * chore: Test that the fee is transferred to the fee collector * Update contracts/ens/DCLControllerV2.sol Co-authored-by: Ignacio Mazzara <nachomazzara@gmail.com> Signed-off-by: Fernando Zavalia <24811313+fzavalia@users.noreply.github.com> * chore: Update test * chore: Update test * chore: Update test --------- Signed-off-by: Fernando Zavalia <24811313+fzavalia@users.noreply.github.com> Co-authored-by: Ignacio Mazzara <nachomazzara@gmail.com> * feat: Validate collector is never address(0) (#45) * feat: Validate fee collector is not address 0 * chore: Test that the fee collector is not 0 * chore: Add full DCLControllerV2 full contract (#46) * feat: Add script to deploy new controller (#47) * feat: Add script to deploy new controller * chore: EOL * chore: Add default network * chore: Add default rpc url for deploy * chore: Remove default network * chore: Rename fixture * feat: Remove mas gas price and validations (#49) * feat: Provide owner on constructor (#51) * feat: Provide owner on constructor * chore: Test transfer ownership * chore: Add natspec * feat: Remove requireBalance function (#53) * feat: Remove requireBalance function * chore: Fix tests * chore: Add comment about which ERC20 tokens should be used (#54) * chore: Add comment about token * chore: Remove * chore: Add comment in contructor * chore: Update comment * chore: Update comment * chore: Remove dot * chore: Deploy mainnet (#55) * chore: Update README * chore: Update deploy script --------- Signed-off-by: Fernando Zavalia <24811313+fzavalia@users.noreply.github.com> Co-authored-by: Gabriel Díaz <gabrieldiaz31@gmail.com> Co-authored-by: Ignacio Mazzara <nachomazzara@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #50